fix(argo-workflows): Add access to be able to see pod information #3191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yorickdevries
requested review from
vladlosev,
jmeridth,
yu-croco and
tico24
as code owners
yorickdevries
changed the title
yorickdevries
changed the title
…5.0 (argoproj#3184) Signed-off-by: Yorick <[email protected]>
…argoproj#3187) Signed-off-by: argoproj-renovate[bot] <161757507+argoproj-renovate[bot]@users.noreply.github.com> Co-authored-by: argoproj-renovate[bot] <161757507+argoproj-renovate[bot]@users.noreply.github.com> Signed-off-by: Yorick <[email protected]>
… runs the workflows (argoproj#3186) * feat(argo-workflows): allow additional rules for service account that runs the workflows Signed-off-by: fuyuan.chu <[email protected]> * Update charts/argo-workflows/templates/controller/workflow-role.yaml Co-authored-by: Aikawa <[email protected]> Signed-off-by: awx-fuyuanchu <[email protected]> --------- Signed-off-by: fuyuan.chu <[email protected]> Signed-off-by: awx-fuyuanchu <[email protected]> Co-authored-by: Aikawa <[email protected]> Signed-off-by: Yorick <[email protected]>
Signed-off-by: Tim Collins <[email protected]> Signed-off-by: Yorick <[email protected]>
…oj#3189) Signed-off-by: Marco Maurer <[email protected]> Signed-off-by: Yorick <[email protected]>
…oj#3190) Signed-off-by: argoproj-renovate[bot] <161757507+argoproj-renovate[bot]@users.noreply.github.com> Co-authored-by: argoproj-renovate[bot] <161757507+argoproj-renovate[bot]@users.noreply.github.com> Co-authored-by: Aikawa <[email protected]> Signed-off-by: Yorick <[email protected]>
Signed-off-by: Yorick <[email protected]>
Signed-off-by: Yorick <[email protected]>
Signed-off-by: Yorick <[email protected]>
yorickdevries
force-pushed
the
pod-view-edit-admin-access
branch
from
027001d to
ec2ea73
Compare
yorickdevries
requested review from
mbevc1,
mkilchhofer and
pdrastil
as code owners
|
This seems to have more changes in than description suggests 🤔 |
# Conflicts: # charts/argo-workflows/Chart.yaml
|
I have concerns with this. Upstream does not include these permissions in their aggregate-to-* roles/clusterroles. So this should be 'addressed' upstream first. However, the argo server should be using the |
6 tasks
|
This PR wasn't properly set up. Sorry for the confusion. I made a new PR here: #3192 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to https://argo-workflows.readthedocs.io/en/latest/security/ UI users need access to pod(logs) to be properly displayed and updated in the argo workflows UI.
In this PR I added these to the view / edit / admin aggregate roles:
Checklist: