fix(argo-cd): Pass commit.server parameter to the application controller to account for the commitServer service name.

[daftping]

• pass commit.server parameter to the application controller to account for the commitServer service name.
• align service definition for commitServer with rest of the chart
• respect global log settings in commitserver component

Diff

diff --recursive .tmp/manifests_old/argo-cd/templates/argocd-application-controller/statefulset.yaml .tmp/manifests_new/argo-cd/templates/argocd-application-controller/statefulset.yaml
27c27
<         checksum/cmd-params: 7f9ab655f97c07d18371fb74e1eed52ab343b2e05812ea40bae8b868fcae8d37
---
>         checksum/cmd-params: 8292fa4e5925f6f9c66e744f6d44187809f0f9d851e09b24506c6fab32061f91
75a76,81
>                 optional: true
>           - name: ARGOCD_APPLICATION_CONTROLLER_COMMIT_SERVER
>             valueFrom:
>               configMapKeyRef:
>                 name: argocd-cmd-params-cm
>                 key: commit.server
diff --recursive .tmp/manifests_old/argo-cd/templates/argocd-applicationset/deployment.yaml .tmp/manifests_new/argo-cd/templates/argocd-applicationset/deployment.yaml
26c26
<         checksum/cmd-params: 7f9ab655f97c07d18371fb74e1eed52ab343b2e05812ea40bae8b868fcae8d37
---
>         checksum/cmd-params: 8292fa4e5925f6f9c66e744f6d44187809f0f9d851e09b24506c6fab32061f91
diff --recursive .tmp/manifests_old/argo-cd/templates/argocd-commit-server/service.yaml .tmp/manifests_new/argo-cd/templates/argocd-commit-server/service.yaml
21c21
<     targetPort: 8086
---
>     targetPort: server
diff --recursive .tmp/manifests_old/argo-cd/templates/argocd-configs/argocd-cmd-params-cm.yaml .tmp/manifests_new/argo-cd/templates/argocd-configs/argocd-cmd-params-cm.yaml
23a24,26
>   commit.server: test-argocd-commit-server:8086
>   commitserver.log.format: text
>   commitserver.log.level: info
diff --recursive .tmp/manifests_old/argo-cd/templates/argocd-repo-server/deployment.yaml .tmp/manifests_new/argo-cd/templates/argocd-repo-server/deployment.yaml
26c26
<         checksum/cmd-params: 7f9ab655f97c07d18371fb74e1eed52ab343b2e05812ea40bae8b868fcae8d37
---
>         checksum/cmd-params: 8292fa4e5925f6f9c66e744f6d44187809f0f9d851e09b24506c6fab32061f91
diff --recursive .tmp/manifests_old/argo-cd/templates/argocd-server/deployment.yaml .tmp/manifests_new/argo-cd/templates/argocd-server/deployment.yaml
26c26
<         checksum/cmd-params: 7f9ab655f97c07d18371fb74e1eed52ab343b2e05812ea40bae8b868fcae8d37
---
>         checksum/cmd-params: 8292fa4e5925f6f9c66e744f6d44187809f0f9d851e09b24506c6fab32061f91
diff --recursive .tmp/manifests_old/argo-cd/templates/dex/deployment.yaml .tmp/manifests_new/argo-cd/templates/dex/deployment.yaml
26c26
<         checksum/cmd-params: 7f9ab655f97c07d18371fb74e1eed52ab343b2e05812ea40bae8b868fcae8d37
---
>         checksum/cmd-params: 8292fa4e5925f6f9c66e744f6d44187809f0f9d851e09b24506c6fab32061f91

Checklist:

• I have bumped the chart version according to versioning
• I have updated the documentation according to documentation
• I have updated the chart changelog with all the changes that come with this pull request according to changelog.
• Any new values are backwards compatible and/or have sensible default.
• I have signed off all my commits as required by DCO.
• My build is green (troubleshooting builds).

[yu-croco]

Hi @daftping , thank you for your PR.
Since we follow upstream's manifest, can you please make PR in upstream at first?

I findARGOCD_APPLICATION_CONTROLLER_COMMIT_SERVER in Golang logic here, but not in manifests/ .