Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(argo-cd): Add support for controller.sync.timeout.seconds #3176

Merged
merged 1 commit into from
Feb 21, 2025
Merged

feat(argo-cd): Add support for controller.sync.timeout.seconds #3176

merged 1 commit into from
Feb 21, 2025

Conversation

fjgcosta
Copy link
Contributor

@fjgcosta fjgcosta commented Feb 21, 2025 •
edited by tico24
Loading

Context

Add support for argoproj/argo-cd#20816
Making this explicit in values.yaml so people wont miss it.

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

@fjgcosta fjgcosta force-pushed the controller_sync_timeout branch 2 times, most recently from 53adbdb to c70ca0d Compare February 21, 2025 15:30
tico24
tico24 requested changes Feb 21, 2025
View reviewed changes
Copy link
Member

@tico24 tico24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite a lot of unncessary changes. Presumably your IDE is "helping".

Please update the changelog. Thanks

@fjgcosta fjgcosta force-pushed the controller_sync_timeout branch from c70ca0d to af7b77a Compare February 21, 2025 15:42
@fjgcosta fjgcosta force-pushed the controller_sync_timeout branch from af7b77a to 029734f Compare February 21, 2025 15:50
@github-actions github-actions bot added size/XS and removed size/L labels Feb 21, 2025
@fjgcosta
Copy link
Contributor Author

Quite a lot of unncessary changes. Presumably your IDE is "helping".

Please update the changelog. Thanks

Fixed

@tico24 tico24 enabled auto-merge (squash) February 21, 2025 15:56
@tico24 tico24 merged commit 7b9f7fb into argoproj:main Feb 21, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbevc1 mbevc1 mbevc1 approved these changes

@tico24 tico24 tico24 approved these changes

@mkilchhofer mkilchhofer Awaiting requested review from mkilchhofer mkilchhofer is a code owner

@yu-croco yu-croco Awaiting requested review from yu-croco yu-croco is a code owner

@jmeridth jmeridth Awaiting requested review from jmeridth jmeridth is a code owner

@pdrastil pdrastil Awaiting requested review from pdrastil pdrastil is a code owner

Assignees
No one assigned
Labels
argo-cd size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fjgcosta @mbevc1 @tico24