-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix project role docs #21832
base: master
Are you sure you want to change the base?
docs: fix project role docs #21832
Conversation
🔴 Preview Environment stopped on BunnyshellSee: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
@klemmster you'll need to signoff your commit
|
@@ -140,15 +140,15 @@ spec: | |||
groups: | |||
- some-user | |||
policies: | |||
- p, proj:sample-test-project:some-role, applications, *, *, allow | |||
- p, proj:sample-test-project:admin, applications, *, *, allow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- p, proj:sample-test-project:admin, applications, *, *, allow | |
- p, proj:sample-test-project:admin, applications, *, *, allow |
This doesn't necessarily need to be an admin
role.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't it?
The role name is taken from a few lines above:
0f3d760#diff-d89745b05f3543cc0beea51e5f2a351f604b8ef117448098e65166afa08c70f5R138
and the explanation says:
A role's policy can only grant access to that role.
From that, my understanding is that this must be the admin
role.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@klemmster you're right, the name is given a few lines above and policies should use the given role name. I guess another option is to rename the role name to some-role
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PTAL
The docs were using the role description, not the role name as handle Signed-off-by: Richard Palm <[email protected]>
0f3d760
to
84517e2
Compare
The docs were using the role description, not the role name as handle
Checklist: