Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(json-schema): handle nullable required props as nullable fields in GraphQL #6563

Merged
merged 2 commits into from
Feb 12, 2024
Merged

fix(json-schema): handle nullable required props as nullable fields in GraphQL #6563

merged 2 commits into from
Feb 12, 2024

Conversation

ardatan
Copy link
Owner

@ardatan ardatan commented Feb 11, 2024 •
edited
Loading

Closes #6561
Fixes #6560

@codesandbox CodeSandbox
Copy link

codesandbox bot commented Feb 11, 2024

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

@ardatan ardatan mentioned this pull request Feb 11, 2024
Closed
9 tasks
@github-actions GitHub Actions
Copy link
Contributor

💻 Website Preview

The latest changes are available as preview in: https://f38cc0ac.graphql-mesh.pages.dev

@github-actions GitHub Actions
Copy link
Contributor

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-mesh/apollo-link 0.97.6-alpha-20240211111324-c150f6f1f0a8be865633ddd3bb66b3bcad5107a1 npm ↗︎ unpkg ↗︎
@graphql-mesh/cache-cfw-kv 0.96.5-alpha-20240211111324-c150f6f1f0a8be865633ddd3bb66b3bcad5107a1 npm ↗︎ unpkg ↗︎
@graphql-mesh/cache-file 0.96.5-alpha-20240211111324-c150f6f1f0a8be865633ddd3bb66b3bcad5107a1 npm ↗︎ unpkg ↗︎
@graphql-mesh/cache-localforage 0.96.5-alpha-20240211111324-c150f6f1f0a8be865633ddd3bb66b3bcad5107a1 npm ↗︎ unpkg ↗︎
@graphql-mesh/cache-redis 0.96.5-alpha-20240211111324-c150f6f1f0a8be865633ddd3bb66b3bcad5107a1 npm ↗︎ unpkg ↗︎
@graphql-mesh/cli 0.88.7-alpha-20240211111324-c150f6f1f0a8be865633ddd3bb66b3bcad5107a1 npm ↗︎ unpkg ↗︎
@graphql-mesh/compose-cli 0.0.2-alpha-20240211111324-c150f6f1f0a8be865633ddd3bb66b3bcad5107a1 npm ↗︎ unpkg ↗︎
@graphql-mesh/config 0.98.6-alpha-20240211111324-c150f6f1f0a8be865633ddd3bb66b3bcad5107a1 npm ↗︎ unpkg ↗︎
@graphql-mesh/fusion-runtime 0.0.2-alpha-20240211111324-c150f6f1f0a8be865633ddd3bb66b3bcad5107a1 npm ↗︎ unpkg ↗︎
@graphql-mesh/graphql 0.96.5-alpha-20240211111324-c150f6f1f0a8be865633ddd3bb66b3bcad5107a1 npm ↗︎ unpkg ↗︎
@graphql-mesh/grpc 0.97.5-alpha-20240211111324-c150f6f1f0a8be865633ddd3bb66b3bcad5107a1 npm ↗︎ unpkg ↗︎
@graphql-mesh/json-schema 0.98.1-alpha-20240211111324-c150f6f1f0a8be865633ddd3bb66b3bcad5107a1 npm ↗︎ unpkg ↗︎
@graphql-mesh/mongoose 0.96.6-alpha-20240211111324-c150f6f1f0a8be865633ddd3bb66b3bcad5107a1 npm ↗︎ unpkg ↗︎
@graphql-mesh/mysql 0.96.6-alpha-20240211111324-c150f6f1f0a8be865633ddd3bb66b3bcad5107a1 npm ↗︎ unpkg ↗︎
@graphql-mesh/neo4j 0.96.6-alpha-20240211111324-c150f6f1f0a8be865633ddd3bb66b3bcad5107a1 npm ↗︎ unpkg ↗︎
@graphql-mesh/odata 0.96.5-alpha-20240211111324-c150f6f1f0a8be865633ddd3bb66b3bcad5107a1 npm ↗︎ unpkg ↗︎
@graphql-mesh/openapi 0.98.1-alpha-20240211111324-c150f6f1f0a8be865633ddd3bb66b3bcad5107a1 npm ↗︎ unpkg ↗︎
@graphql-mesh/postgraphile 0.96.5-alpha-20240211111324-c150f6f1f0a8be865633ddd3bb66b3bcad5107a1 npm ↗︎ unpkg ↗︎
@graphql-mesh/raml 0.98.1-alpha-20240211111324-c150f6f1f0a8be865633ddd3bb66b3bcad5107a1 npm ↗︎ unpkg ↗︎
@graphql-mesh/soap 0.96.6-alpha-20240211111324-c150f6f1f0a8be865633ddd3bb66b3bcad5107a1 npm ↗︎ unpkg ↗︎
@graphql-mesh/supergraph 0.1.5-alpha-20240211111324-c150f6f1f0a8be865633ddd3bb66b3bcad5107a1 npm ↗︎ unpkg ↗︎
@graphql-mesh/thrift 0.97.3-alpha-20240211111324-c150f6f1f0a8be865633ddd3bb66b3bcad5107a1 npm ↗︎ unpkg ↗︎
@graphql-mesh/tuql 0.97.4-alpha-20240211111324-c150f6f1f0a8be865633ddd3bb66b3bcad5107a1 npm ↗︎ unpkg ↗︎
@graphql-mesh/http 0.97.6-alpha-20240211111324-c150f6f1f0a8be865633ddd3bb66b3bcad5107a1 npm ↗︎ unpkg ↗︎
@omnigraph/json-schema 0.98.1-alpha-20240211111324-c150f6f1f0a8be865633ddd3bb66b3bcad5107a1 npm ↗︎ unpkg ↗︎
@omnigraph/mysql 0.0.4-alpha-20240211111324-c150f6f1f0a8be865633ddd3bb66b3bcad5107a1 npm ↗︎ unpkg ↗︎
@omnigraph/neo4j 0.0.4-alpha-20240211111324-c150f6f1f0a8be865633ddd3bb66b3bcad5107a1 npm ↗︎ unpkg ↗︎
@omnigraph/openapi 0.98.1-alpha-20240211111324-c150f6f1f0a8be865633ddd3bb66b3bcad5107a1 npm ↗︎ unpkg ↗︎
@omnigraph/raml 0.98.1-alpha-20240211111324-c150f6f1f0a8be865633ddd3bb66b3bcad5107a1 npm ↗︎ unpkg ↗︎
@omnigraph/soap 0.96.6-alpha-20240211111324-c150f6f1f0a8be865633ddd3bb66b3bcad5107a1 npm ↗︎ unpkg ↗︎
@omnigraph/sqlite 0.0.5-alpha-20240211111324-c150f6f1f0a8be865633ddd3bb66b3bcad5107a1 npm ↗︎ unpkg ↗︎
@omnigraph/thrift 0.0.4-alpha-20240211111324-c150f6f1f0a8be865633ddd3bb66b3bcad5107a1 npm ↗︎ unpkg ↗︎
@graphql-mesh/merger-bare 0.96.5-alpha-20240211111324-c150f6f1f0a8be865633ddd3bb66b3bcad5107a1 npm ↗︎ unpkg ↗︎
@graphql-mesh/merger-federation 0.96.5-alpha-20240211111324-c150f6f1f0a8be865633ddd3bb66b3bcad5107a1 npm ↗︎ unpkg ↗︎
@graphql-mesh/merger-stitching 0.96.5-alpha-20240211111324-c150f6f1f0a8be865633ddd3bb66b3bcad5107a1 npm ↗︎ unpkg ↗︎
@graphql-mesh/plugin-deduplicate-request 0.96.5-alpha-20240211111324-c150f6f1f0a8be865633ddd3bb66b3bcad5107a1 npm ↗︎ unpkg ↗︎
@graphql-mesh/plugin-hive 0.96.7-alpha-20240211111324-c150f6f1f0a8be865633ddd3bb66b3bcad5107a1 npm ↗︎ unpkg ↗︎
@graphql-mesh/plugin-http-cache 0.96.5-alpha-20240211111324-c150f6f1f0a8be865633ddd3bb66b3bcad5107a1 npm ↗︎ unpkg ↗︎
@graphql-mesh/plugin-http-details-extensions 0.96.5-alpha-20240211111324-c150f6f1f0a8be865633ddd3bb66b3bcad5107a1 npm ↗︎ unpkg ↗︎
@graphql-mesh/plugin-live-query 0.96.5-alpha-20240211111324-c150f6f1f0a8be865633ddd3bb66b3bcad5107a1 npm ↗︎ unpkg ↗︎
@graphql-mesh/plugin-mock 0.96.5-alpha-20240211111324-c150f6f1f0a8be865633ddd3bb66b3bcad5107a1 npm ↗︎ unpkg ↗︎
@graphql-mesh/plugin-newrelic 0.96.5-alpha-20240211111324-c150f6f1f0a8be865633ddd3bb66b3bcad5107a1 npm ↗︎ unpkg ↗︎
@graphql-mesh/plugin-operation-field-permissions 0.96.5-alpha-20240211111324-c150f6f1f0a8be865633ddd3bb66b3bcad5107a1 npm ↗︎ unpkg ↗︎
@graphql-mesh/plugin-prometheus 0.96.6-alpha-20240211111324-c150f6f1f0a8be865633ddd3bb66b3bcad5107a1 npm ↗︎ unpkg ↗︎
@graphql-mesh/plugin-rate-limit 0.96.6-alpha-20240211111324-c150f6f1f0a8be865633ddd3bb66b3bcad5107a1 npm ↗︎ unpkg ↗︎
@graphql-mesh/plugin-response-cache 0.96.7-alpha-20240211111324-c150f6f1f0a8be865633ddd3bb66b3bcad5107a1 npm ↗︎ unpkg ↗︎
@graphql-mesh/plugin-snapshot 0.96.5-alpha-20240211111324-c150f6f1f0a8be865633ddd3bb66b3bcad5107a1 npm ↗︎ unpkg ↗︎
@graphql-mesh/plugin-statsd 0.96.5-alpha-20240211111324-c150f6f1f0a8be865633ddd3bb66b3bcad5107a1 npm ↗︎ unpkg ↗︎
@graphql-mesh/runtime 0.97.6-alpha-20240211111324-c150f6f1f0a8be865633ddd3bb66b3bcad5107a1 npm ↗︎ unpkg ↗︎
@graphql-mesh/serve-cli 0.1.0-alpha-20240211111324-c150f6f1f0a8be865633ddd3bb66b3bcad5107a1 npm ↗︎ unpkg ↗︎
@graphql-mesh/serve-runtime 0.0.2-alpha-20240211111324-c150f6f1f0a8be865633ddd3bb66b3bcad5107a1 npm ↗︎ unpkg ↗︎
@graphql-mesh/store 0.96.5-alpha-20240211111324-c150f6f1f0a8be865633ddd3bb66b3bcad5107a1 npm ↗︎ unpkg ↗︎
@graphql-mesh/transform-cache 0.96.5-alpha-20240211111324-c150f6f1f0a8be865633ddd3bb66b3bcad5107a1 npm ↗︎ unpkg ↗︎
@graphql-mesh/transform-encapsulate 0.96.5-alpha-20240211111324-c150f6f1f0a8be865633ddd3bb66b3bcad5107a1 npm ↗︎ unpkg ↗︎
@graphql-mesh/transform-extend 0.96.5-alpha-20240211111324-c150f6f1f0a8be865633ddd3bb66b3bcad5107a1 npm ↗︎ unpkg ↗︎
@graphql-mesh/transform-federation 0.96.5-alpha-20240211111324-c150f6f1f0a8be865633ddd3bb66b3bcad5107a1 npm ↗︎ unpkg ↗︎
@graphql-mesh/transform-filter-schema 0.96.5-alpha-20240211111324-c150f6f1f0a8be865633ddd3bb66b3bcad5107a1 npm ↗︎ unpkg ↗︎
@graphql-mesh/transform-hive 0.96.7-alpha-20240211111324-c150f6f1f0a8be865633ddd3bb66b3bcad5107a1 npm ↗︎ unpkg ↗︎
@graphql-mesh/transform-hoist-field 0.96.5-alpha-20240211111324-c150f6f1f0a8be865633ddd3bb66b3bcad5107a1 npm ↗︎ unpkg ↗︎
@graphql-mesh/transform-naming-convention 0.96.5-alpha-20240211111324-c150f6f1f0a8be865633ddd3bb66b3bcad5107a1 npm ↗︎ unpkg ↗︎
@graphql-mesh/transform-prefix 0.96.5-alpha-20240211111324-c150f6f1f0a8be865633ddd3bb66b3bcad5107a1 npm ↗︎ unpkg ↗︎
@graphql-mesh/transform-prune 0.96.5-alpha-20240211111324-c150f6f1f0a8be865633ddd3bb66b3bcad5107a1 npm ↗︎ unpkg ↗︎
@graphql-mesh/transform-rate-limit 0.96.5-alpha-20240211111324-c150f6f1f0a8be865633ddd3bb66b3bcad5107a1 npm ↗︎ unpkg ↗︎
@graphql-mesh/transform-rename 0.96.6-alpha-20240211111324-c150f6f1f0a8be865633ddd3bb66b3bcad5107a1 npm ↗︎ unpkg ↗︎
@graphql-mesh/transform-replace-field 0.96.5-alpha-20240211111324-c150f6f1f0a8be865633ddd3bb66b3bcad5107a1 npm ↗︎ unpkg ↗︎
@graphql-mesh/transform-resolvers-composition 0.96.5-alpha-20240211111324-c150f6f1f0a8be865633ddd3bb66b3bcad5107a1 npm ↗︎ unpkg ↗︎
@graphql-mesh/transform-transfer-schema 0.96.5-alpha-20240211111324-c150f6f1f0a8be865633ddd3bb66b3bcad5107a1 npm ↗︎ unpkg ↗︎
@graphql-mesh/transform-type-merging 0.96.5-alpha-20240211111324-c150f6f1f0a8be865633ddd3bb66b3bcad5107a1 npm ↗︎ unpkg ↗︎
@graphql-mesh/transport-common 0.0.2-alpha-20240211111324-c150f6f1f0a8be865633ddd3bb66b3bcad5107a1 npm ↗︎ unpkg ↗︎
@graphql-mesh/transport-http 0.0.2-alpha-20240211111324-c150f6f1f0a8be865633ddd3bb66b3bcad5107a1 npm ↗︎ unpkg ↗︎
@graphql-mesh/transport-mysql 0.0.1-alpha-20240211111324-c150f6f1f0a8be865633ddd3bb66b3bcad5107a1 npm ↗︎ unpkg ↗︎
@graphql-mesh/transport-neo4j 0.0.1-alpha-20240211111324-c150f6f1f0a8be865633ddd3bb66b3bcad5107a1 npm ↗︎ unpkg ↗︎
@graphql-mesh/transport-rest 0.0.2-alpha-20240211111324-c150f6f1f0a8be865633ddd3bb66b3bcad5107a1 npm ↗︎ unpkg ↗︎
@graphql-mesh/transport-soap 0.0.2-alpha-20240211111324-c150f6f1f0a8be865633ddd3bb66b3bcad5107a1 npm ↗︎ unpkg ↗︎
@graphql-mesh/transport-sqlite 0.0.1-alpha-20240211111324-c150f6f1f0a8be865633ddd3bb66b3bcad5107a1 npm ↗︎ unpkg ↗︎
@graphql-mesh/transport-thrift 0.0.1-alpha-20240211111324-c150f6f1f0a8be865633ddd3bb66b3bcad5107a1 npm ↗︎ unpkg ↗︎
@graphql-mesh/types 0.96.5-alpha-20240211111324-c150f6f1f0a8be865633ddd3bb66b3bcad5107a1 npm ↗︎ unpkg ↗︎
@graphql-mesh/urql-exchange 0.97.6-alpha-20240211111324-c150f6f1f0a8be865633ddd3bb66b3bcad5107a1 npm ↗︎ unpkg ↗︎
@graphql-mesh/utils 0.96.5-alpha-20240211111324-c150f6f1f0a8be865633ddd3bb66b3bcad5107a1 npm ↗︎ unpkg ↗︎

@FGoessler
Copy link
Contributor

Thanks for the quick response and fix! Seem so far good to me! 🌟

We'll check this out tomorrow via the alpha build in our main project with our more complex use-case as well.

@ardatan ardatan merged commit 2138dea into master Feb 12, 2024
@ardatan ardatan deleted the nullable-required branch February 12, 2024 03:11
@github-actions github-actions bot mentioned this pull request Feb 12, 2024
Merged
@FGoessler
Copy link
Contributor

Works great for our use-cases with the alpha builds! Tanks so much for this quick response and fix! 🙏 🌟

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JSON-Schema issues with required + nullable=true fields
2 participants
@ardatan @FGoessler