Improve version output for local builds - see #831 (#834)

README.md

@@ -42,6 +42,8 @@ Alternatively, install with Go:
 go get -u github.com/tfsec/tfsec/cmd/tfsec
 ```
 
+Please note that using `go get` will install directly from the `master` branch and version numbers will not be reported via `tfsec --version`.
+
 ## Usage
 
 tfsec will scan the specified directory. If no directory is specified, the current working directory will be used.

cmd/tfsec/main.go

@@ -99,7 +99,11 @@ var rootCmd = &cobra.Command{
 		}
 
 		if showVersion {
-			fmt.Println(version.Version)
+			if version.Version == "" {
+				fmt.Println("You are running a locally built version of tfsec.")
+			} else {
+				fmt.Println(version.Version)
+			}
 			os.Exit(0)
 		}
 

internal/app/tfsec/updater/updater.go

@@ -18,8 +18,8 @@ type githubRelease struct {
 }
 
 func Update() error {
-	if version.Version == "development" {
-		return fmt.Errorf("you are running a development branch")
+	if version.Version == "" {
+		return fmt.Errorf("you are running a locally built version")
 	}
 
 	latestAvailable, err := getLatestVersion()

version/version.go

@@ -1,4 +1,4 @@
 package version
 
 // Version is automatically set using ldflags on build/release. Describes built version of tfsec.
-var Version = "development"
+var Version = ""