-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Move existing middlewares to a middlewares folder and added pass through middleware for packages #39410
base: release
Are you sure you want to change the base?
Conversation
…ss through middleware for packages
WalkthroughThis pull request makes several adjustments to the codebase’s module exports and file organization. The Changes
Sequence Diagram(s)sequenceDiagram
participant ActionSender as Action Sender
participant PackageMW as PackageMiddleware
participant Next as Next Middleware/Reducer
ActionSender->>PackageMW: Dispatch Action
PackageMW->>Next: Forward action
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (5)
💤 Files with no reviewable changes (1)
✅ Files skipped from review due to trivial changes (2)
🔇 Additional comments (2)
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Description
Move middlewares to a new folder and added an ee specific middleware
app/client/src/ee/middlewares/PackageMiddleware.ts
.This will eventually be added to the store but as of now it is detached since the functionality is incomplete. It will be extended in EE
PR for https://github.com/appsmithorg/appsmith-ee/pull/6324
Automation
/ok-to-test tags="@tag.All"
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/13493097420
Commit: a0a94db
Cypress dashboard.
Tags:
@tag.All
Spec:
Mon, 24 Feb 2025 08:58:32 UTC
Communication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit
New Features
Refactor