chore: add rollup config for wds #39397
+2,048
−1,468
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,11 +4,16 @@ | |
| "main": "src/index.ts", | ||
| "author": "Valera Melnikov <[email protected]>, Pawan Kumar <[email protected]>", | ||
| "license": "MIT", | ||
| "type": "module", | ||
| "files": [ | ||
| "build" | ||
| ], | ||
| "scripts": { | ||
| "lint": "yarn g:lint", | ||
| "prettier": "yarn g:prettier", | ||
| "test:unit": "yarn g:jest", | ||
| "build:icons": "npx tsx ./src/scripts/build-icons.ts", | ||
| "build:package": "rm -rf build && rollup -c rollup.config.js" | ||
| }, | ||
| "dependencies": { | ||
| "@appsmith/wds-headless": "workspace:^", | ||
|
|
@@ -34,12 +39,32 @@ | |
| "usehooks-ts": "*" | ||
| }, | ||
| "devDependencies": { | ||
| "@babel/core": "^7.26.9", | ||
| "@babel/helper-compilation-targets": "^7.26.5", | ||
| "@babel/preset-env": "^7.26.9", | ||
| "@babel/preset-react": "^7.26.3", | ||
| "@babel/preset-typescript": "^7.26.0", | ||
| "@babel/runtime": "^7.26.9", | ||
| "@rollup/plugin-babel": "^6.0.4", | ||
| "@rollup/plugin-commonjs": "^28.0.2", | ||
| "@rollup/plugin-image": "^3.0.3", | ||
| "@rollup/plugin-node-resolve": "^16.0.0", | ||
| "@rollup/plugin-replace": "^6.0.2", | ||
| "@rollup/plugin-terser": "^0.4.4", | ||
| "@rollup/plugin-typescript": "^12.1.2", | ||
| "@rollup/plugin-url": "^8.0.2", | ||
| "@types/fs-extra": "^11.0.4", | ||
| "@types/react-syntax-highlighter": "^15.5.13", | ||
| "@types/react-transition-group": "^4.4.12", | ||
| "browserslist": "^4.24.4", | ||
| "eslint-plugin-storybook": "^0.11.3", | ||
| "postcss-import": "^16.1.0", | ||
| "rollup": "^4.34.8", | ||
| "rollup-plugin-copy": "^3.5.0", | ||
| "rollup-plugin-postcss": "^4.0.2" | ||
| }, | ||
| "peerDependencies": { | ||
| "react": "^16.8.0 || ^17.0.0-rc.1 || ^18.0.0", | ||
| "react-dom": "^16.8.0 || ^17.0.0-rc.1 || ^18.0.0" | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,93 @@ | ||
| import path from "path"; | ||
| import { dirname } from "path"; | ||
| import { fileURLToPath } from "url"; | ||
| import { defineConfig } from "rollup"; | ||
|
|
||
| import postcssNesting from "postcss-nesting"; | ||
| import postcssImport from "postcss-import"; | ||
| import postcssAtRulesVariables from "postcss-at-rules-variables"; | ||
| import postcssEach from "postcss-each"; | ||
| import postcssModulesValues from "postcss-modules-values"; | ||
|
|
||
| const __filename = fileURLToPath(import.meta.url); | ||
| const __dirname = dirname(__filename); | ||
|
|
||
| import json from "@rollup/plugin-json"; | ||
| import resolve from "@rollup/plugin-node-resolve"; | ||
| import commonjs from "@rollup/plugin-commonjs"; | ||
| import typescript from "@rollup/plugin-typescript"; | ||
| import postcss from "rollup-plugin-postcss"; | ||
| import babel from "@rollup/plugin-babel"; | ||
| import replace from "@rollup/plugin-replace"; | ||
|
|
||
| const BUILD_DIR = path.resolve(__dirname, "build"); | ||
|
|
||
| const EXTERNALS = ["react", "react-dom"]; | ||
|
|
||
| export default defineConfig({ | ||
| input: path.resolve(__dirname, "src/index.ts"), | ||
| output: { | ||
| file: path.resolve(BUILD_DIR, "bundle.js"), | ||
| format: "esm", | ||
| sourcemap: true, | ||
| inlineDynamicImports: true, | ||
| globals: { | ||
| react: "React", | ||
| "react-dom": "ReactDOM", | ||
| }, | ||
| }, | ||
| external: EXTERNALS, | ||
| plugins: [ | ||
| json(), | ||
| replace({ | ||
| preventAssignment: true, | ||
| values: { | ||
| "process.env.NODE_ENV": JSON.stringify("production"), | ||
| "process.env.REACT_APP_ENV": JSON.stringify("production"), | ||
| }, | ||
| }), | ||
| commonjs({ | ||
| include: /node_modules/, | ||
| transformMixedEsModules: true, | ||
| requireReturnsDefault: "preferred", | ||
| esmExternals: true, | ||
| }), | ||
| babel({ | ||
| exclude: "node_modules/**", | ||
| babelHelpers: "bundled", | ||
| extensions: [".js", ".jsx", ".ts", ".tsx"], | ||
| presets: [ | ||
| ["@babel/preset-react", { runtime: "automatic" }], | ||
| ["@babel/preset-typescript", { isTSX: true, allExtensions: true }], | ||
| ], | ||
| skipPreflightCheck: true, | ||
| babelrc: false, | ||
| configFile: false, | ||
| }), | ||
| postcss({ | ||
| modules: true, | ||
| minimize: true, | ||
| sourceMap: true, | ||
| plugins: [ | ||
| postcssNesting(), | ||
| postcssImport(), | ||
| postcssAtRulesVariables(), | ||
| postcssEach(), | ||
| postcssModulesValues(), | ||
| ], | ||
| }), | ||
| typescript({ | ||
| tsconfig: "./tsconfig.json", | ||
| declaration: true, | ||
| declarationDir: path.resolve(BUILD_DIR), | ||
| rootDir: "src", | ||
| outDir: path.resolve(BUILD_DIR), | ||
| }), | ||
|
Comment on lines
+79
to
+85
There was a problem hiding this comment. 💡 Verification agent 🧩 Analysis chainVerify TypeScript configuration exists. Make sure the referenced tsconfig.json exists and has compatible settings. 🏁 Script executed: #!/bin/bash
# Check if tsconfig.json exists and has compatible settings
if [ -f "./tsconfig.json" ]; then
echo "tsconfig.json exists"
grep -E "\"jsx\":|\"jsxFactory\":|\"target\":|\"module\":" ./tsconfig.json
else
echo "tsconfig.json does not exist"
fiLength of output: 95 Action Required: Update the TypeScript configuration reference. The rollup configuration references |
||
| resolve({ | ||
| extensions: [".js", ".jsx", ".ts", ".tsx"], | ||
| browser: true, | ||
| preferBuiltins: false, | ||
| dedupe: EXTERNALS, | ||
| }), | ||
| ], | ||
| }); | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,8 @@ | ||
| import { useHotKeysView } from "./useHotKeysView"; | ||
| import useOps from "git/hooks/useOps"; | ||
|
|
||
| export function useHotKeys() { | ||
| const { toggleOpsModal } = useOps(); | ||
|
|
||
| return useHotKeysView({ toggleOpsModal }); | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| import { GitOpsTab } from "git/constants/enums"; | ||
| import noop from "lodash/noop"; | ||
| import { useCallback } from "react"; | ||
|
|
||
| interface HotKeysViewProps { | ||
| toggleOpsModal: (show: boolean, tab?: GitOpsTab.Deploy) => void; | ||
| } | ||
|
|
||
| export function useHotKeysView({ toggleOpsModal = noop }: HotKeysViewProps) { | ||
| const handleCommitModal = useCallback(() => { | ||
| toggleOpsModal(true, GitOpsTab.Deploy); | ||
| }, [toggleOpsModal]); | ||
|
|
||
| return [ | ||
| { | ||
| combo: "ctrl + shift + g", | ||
| global: true, | ||
| label: "Show git commit modal", | ||
| onKeyDown: handleCommitModal, | ||
| }, | ||
| ]; | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to check if this affects the current work of the package in the main app.