Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch integration tests to newer Swift test matrix #150

Merged
merged 1 commit into from
Apr 8, 2025

Conversation

rnro
Copy link
Contributor

@rnro rnro commented Apr 8, 2025

Switch integration tests to newer Swift test matrix

Motivation:

To remove all uses of the older workflow so it can be removed to
simplify the workflows.

Modifications:

  • Switch integration tests to use the newer Swift test matrix workflow,
    swift_test_matrix.yml
  • As part of this I had to add a git config command to the setup
    instructions. Lots of other repos have been using the matrix workflow
    without needing this so I'm unsure of why it's needed here. If it
    becomes common I'll look at a central way to include this.

Result:

This should make no difference to the running of integration tests.

@rnro rnro force-pushed the adopt_swift_test_matrix_workflow branch from 39ed4bd to 3467785 Compare April 8, 2025 14:47
Motivation:

To remove all uses of the older workflow so it can be removed to
simplify the workflows.

Modifications:

* Switch integration tests to use the newer Swift test matrix workflow,
  `swift_test_matrix.yml`
* As part of this I had to add a git config command to the setup
  instructions. Lots of other repos have been using the matrix workflow
  without needing this so I'm unsure of why it's needed here. If it
  becomes common I'll look at a central way to include this.

Result:

This should make no difference to the running of integration tests.
@rnro rnro force-pushed the adopt_swift_test_matrix_workflow branch from 5f91fd8 to 21c25ab Compare April 8, 2025 15:08
@rnro rnro changed the title WIP Switch integration tests to newer Swift test matrix Apr 8, 2025
@rnro rnro added the semver/none No version bump required. label Apr 8, 2025
@rnro rnro marked this pull request as ready for review April 8, 2025 15:19
@simonjbeaumont simonjbeaumont merged commit e2395f4 into main Apr 8, 2025
30 of 31 checks passed
@simonjbeaumont simonjbeaumont deleted the adopt_swift_test_matrix_workflow branch April 8, 2025 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/none No version bump required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants