Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRO-6775: External frontend support, bugfix, debug mode #10

Merged
merged 3 commits into from
Nov 11, 2024

Conversation

myovchev
Copy link
Contributor

@myovchev myovchev commented Nov 8, 2024

Summary

  • Adds module debug logs when in asset debug mode (APOS_ASSETS_DEBUG=1).
  • Adds an option for disabling the module preload polyfill.
  • Adds support for synthetic entrypoints, that will only process the entrypoint prologue.
  • Don't crash when there is no entrypoint of type index.

What are the specific steps to test this change?

What kind of change does this PR introduce?

(Check at least one)

  • Bug fix
  • New feature
  • Refactor
  • Documentation
  • Build-related changes
  • Other

Make sure the PR fulfills these requirements:

  • It includes a) the existing issue ID being resolved, b) a convincing reason for adding this feature, or c) a clear description of the bug it resolves
  • The changelog is updated
  • Related documentation has been updated
  • Related tests have been updated

If adding a new feature without an already open issue, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

Copy link

linear bot commented Nov 8, 2024

@myovchev myovchev requested a review from haroun November 8, 2024 13:12
@myovchev myovchev changed the title PRO-6775:: External frontend support, bugfix, debug mode PRO-6775: External frontend support, bugfix, debug mode Nov 8, 2024
applyModulePreloadPolyfill(entrypoints) {
//
// The polyfill will be skipped for external frontends. External frontends
// are responsible for including the polyfill themselves if needed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this explained in our official documentation?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this should be addressed by Bob on the release data (by the Changelog entries)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's also a core option, that has an entry in the core CHANGELOG.

@myovchev myovchev merged commit a4b0cc3 into main Nov 11, 2024
4 checks passed
@myovchev myovchev deleted the PRO-6775-external-frontend branch November 11, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants