-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: errors with CREATE TABLE LIKE when the original table has indexes #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cool! This also addresses #29. |
GaoYusong
reviewed
Sep 4, 2024
GaoYusong
reviewed
Sep 4, 2024
GaoYusong
reviewed
Sep 4, 2024
GaoYusong
reviewed
Sep 4, 2024
GaoYusong
reviewed
Sep 4, 2024
i've completed the review, let's fix the issues and merge it into the main branch! |
GaoYusong
reviewed
Sep 5, 2024
GaoYusong
reviewed
Sep 5, 2024
GaoYusong
reviewed
Sep 5, 2024
GaoYusong
reviewed
Sep 5, 2024
there's an error in the CI, please address it --- FAIL: TestUnbuildableIndex (0.58s)
--- FAIL: TestUnbuildableIndex/Failing_index_builder_still_returning_correct_results (0.40s)
--- FAIL: TestUnbuildableIndex/Failing_index_builder_still_returning_correct_results/SELECT_i_FROM_mytable2_WHERE_i_IN_(SELECT_i_FROM_mytable2)_ORDER_BY_i (0.14s)
panic: runtime error: index out of range [0] with length 0 [recovered]
panic: runtime error: index out of range [0] with length 0 [recovered]
panic: runtime error: index out of range [0] with length 0 |
GaoYusong
requested changes
Sep 5, 2024
GaoYusong
requested changes
Sep 6, 2024
GaoYusong
reviewed
Sep 6, 2024
GaoYusong
reviewed
Sep 6, 2024
GaoYusong
reviewed
Sep 6, 2024
GaoYusong
reviewed
Sep 6, 2024
GaoYusong
reviewed
Sep 9, 2024
GaoYusong
reviewed
Sep 9, 2024
GaoYusong
reviewed
Sep 9, 2024
GaoYusong
approved these changes
Sep 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Congrats on your first PR! It’s a long journey to get it merged, but I hope the next one will go more quickly.
GaoYusong
added a commit
that referenced
this pull request
Sep 12, 2024
GaoYusong
added a commit
that referenced
this pull request
Sep 12, 2024
GaoYusong
added a commit
that referenced
this pull request
Sep 12, 2024
GaoYusong
added a commit
that referenced
this pull request
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the process of copying a table and creating an index, the parameters passed only included the index name without binding the index to the column names, resulting in a syntax error. The root cause is that when creating the index, the Exprs value was not assigned.
Currently, the column names are extracted from the SQL and assigned to Exprs, but it only supports single-column or multi-column indexes.
fixes #26
fixes #29