Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improve] Add h2 dialect usage documentation #389

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

[Improve] Add h2 dialect usage documentation #389

wants to merge 3 commits into from

Conversation

VampireAchao
Copy link
Contributor

@VampireAchao VampireAchao requested a review from wolfboys June 16, 2024 09:48
@caicancai
Copy link
Member

You didn't explain what h2 can configure. Do these configurations need a simple parameter list? Otherwise, I don't think it makes much sense to add them.

@wolfboys
Copy link
Member

Thanks for your contribution, but this document is indeed incomplete. It should clearly explain to users the purpose of h2, how to configure the data-dir/ username and password, and how to access the h2 management page...

@VampireAchao
Copy link
Contributor Author

You didn't explain what h2 can configure. Do these configurations need a simple parameter list? Otherwise, I don't think it makes much sense to add them.

Thx for review,I'll modify them

@VampireAchao
Copy link
Contributor Author

Thanks for your contribution, but this document is indeed incomplete. It should clearly explain to users the purpose of h2, how to configure the data-dir/ username and password, and how to access the h2 management page...

Ok. 😄

@VampireAchao VampireAchao marked this pull request as draft June 17, 2024 08:13
@VampireAchao VampireAchao changed the title [improve] Add h2 dialect usage documentation [Draft] Add h2 dialect usage documentation Jun 17, 2024
@VampireAchao VampireAchao changed the title [Draft] Add h2 dialect usage documentation [Improve] Add h2 dialect usage documentation Jun 18, 2024
@VampireAchao VampireAchao requested a review from caicancai June 18, 2024 16:08
@VampireAchao VampireAchao marked this pull request as ready for review June 18, 2024 16:09
@VampireAchao
Copy link
Contributor Author

PTAL @caicancai @wolfboys

@caicancai
Copy link
Member

caicancai commented Jun 19, 2024 •
edited
Loading

I tried to develop on Windows and Mac. I think it is not very friendly to Windows. I suggest to explain it first. This function is currently best developed on Linux and Mac.
cc @wolfboys

@VampireAchao
Copy link
Contributor Author

I tried to develop on Windows and Mac. I think it is not very friendly to Windows. I suggest to explain it first. This function is currently best developed on Linux and Mac. cc @wolfboys

I don't quite understand what you mean. Could you explain how I should modify the documentation? Specifically, what adjustments are needed to make this feature more friendly on Windows, or should I explicitly mention the limitations on Windows in the documentation? Thank you!

@VampireAchao
Copy link
Contributor Author

I tried to develop on Windows and Mac. I think it is not very friendly to Windows. I suggest to explain it first. This function is currently best developed on Linux and Mac. cc @wolfboys

I don't quite understand what you mean. Could you explain how I should modify the documentation? Specifically, what adjustments are needed to make this feature more friendly on Windows, or should I explicitly mention the limitations on Windows in the documentation? Thank you! @caicancai

@wolfboys wolfboys changed the base branch from dev to main August 18, 2024 16:21
@wolfboys wolfboys changed the base branch from main to dev August 18, 2024 16:29
RocMarshal
RocMarshal reviewed Feb 5, 2025
View reviewed changes
i18n/zh-CN/docusaurus-plugin-content-docs/current/get-started/3.dockerDeployment.md

用户名和密码: 默认的用户名为 admin，密码为 streampark

同时下方也可以配置Mysql、Pgsql进行持久化
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
同时下方也可以配置Mysql、Pgsql进行持久化
同时下方也可以配置 MySQL、PgSQL 进行持久化

docs/get-started/3.dockerDeployment.md

Username and password: The default username is admin, the password is streampark

Below, you can configure Mysql or Pgsql for persistence.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Below, you can configure Mysql or Pgsql for persistence.
Below, you can configure MySQL or PgSQL for persistence.

@RocMarshal
Copy link
Contributor

RocMarshal commented Feb 5, 2025 •
edited
Loading

Thanks @VampireAchao for the contribution & @caicancai @wolfboys for the review.
BTW, @VampireAchao Would you mind keeping the same style with https://streampark.apache.org/community/submit_guide/documentation_style_guide for the page?

eg.

  • the limited length of the lines
  • ...

wolfboys
wolfboys reviewed Feb 5, 2025
View reviewed changes
i18n/zh-CN/docusaurus-plugin-content-docs/current/get-started/3.dockerDeployment.md

H2 是一个体积小、性能高、易于嵌入 Java 应用程序的轻量级嵌入式关系型数据库。与 MySQL 有着相似的语法，并且支持数据持久化。StreamPark 默认使用 H2 数据库，使开发者能够快速开始项目

为了实现数据的持久化存储，您可以配置 datasource.h2-data-dir 参数来指定数据文件的存储路径。这确保了即便重启服务，数据也不会丢失
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

从 2.1.5 开始，StreamPark 支持了 h2 数据文件的本地持久化(系统重启后，数据不丢失), 您可以配置....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolfboys wolfboys wolfboys left review comments

@RocMarshal RocMarshal RocMarshal left review comments

@caicancai caicancai Awaiting requested review from caicancai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@VampireAchao @caicancai @wolfboys @RocMarshal