Skip to content

Commit

Permalink
add serialVersionUID field to class which implement Serializable inte…
Browse files Browse the repository at this point in the history
…rface
  • Loading branch information
howardliu-cn committed Jan 14, 2020
1 parent d81b06e commit b700a24
Show file tree
Hide file tree
Showing 108 changed files with 120 additions and 17 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -153,8 +153,8 @@ static void printMetrics(Nimbus.Iface client, String name) throws Exception {
}

public static class ConstBolt extends BaseRichBolt {
public static final String FIELDS = "message";
private static final long serialVersionUID = -5313598399155365865L;
public static final String FIELDS = "message";
private static final Logger log = LoggerFactory.getLogger(ConstBolt.class);
int count = 0;
private OutputCollector collector;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@
*
* @author tgoetz
*/
@SuppressWarnings("serial")
public class GenericBolt extends BaseRichBolt {
private static final long serialVersionUID = 8669713806304573619L;
private static final Logger LOG = LoggerFactory.getLogger(GenericBolt.class);
private OutputCollector collector;
private boolean autoAck = false;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
import org.slf4j.LoggerFactory;

public class KafkaSpoutTestBolt extends BaseRichBolt {
private static final long serialVersionUID = -2971714387602762051L;
protected static final Logger LOG = LoggerFactory.getLogger(KafkaSpoutTestBolt.class);
private OutputCollector collector;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
*/
public class InputStream implements Serializable {
private static final Logger LOG = LoggerFactory.getLogger(InputStream.class);
private static final long serialVersionUID = -6336477049725202777L;
public final String fromComponent;
public final String toComponent;
public final String id;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
* A bolt that simulates a real world bolt based off of statistics about it.
*/
public class LoadBolt extends BaseRichBolt {
private static final long serialVersionUID = 9147991310167687246L;
private static final Logger LOG = LoggerFactory.getLogger(LoadBolt.class);
private final List<OutputStream> outputStreamStats;
private List<OutputStreamEngine> outputStreams;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
*/
public class NormalDistStats implements Serializable {
private static final Logger LOG = LoggerFactory.getLogger(NormalDistStats.class);
private static final long serialVersionUID = -303929340157333380L;
public final double mean;
public final double stddev;
public final double min;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ public static void main(String[] args) throws Exception {
}

private static class ThrottledBolt extends BaseRichBolt {
private static final long serialVersionUID = -8621048146348639308L;
private static final org.slf4j.Logger LOG = LoggerFactory.getLogger(ThrottledBolt.class);
private OutputCollector collector;
private long sleepMs;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,7 @@ public void ack(Object msgId) {
}

private static class LatencyPrintBolt extends BaseRichBolt {
private static final long serialVersionUID = -3566535176387956870L;
private static final org.slf4j.Logger LOG = LoggerFactory.getLogger(LatencyPrintBolt.class);
private OutputCollector collector;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@


public class DevNullBolt extends BaseRichBolt {
private static final long serialVersionUID = 3353976718364358702L;
private static final org.slf4j.Logger LOG = LoggerFactory.getLogger(DevNullBolt.class);
private OutputCollector collector;
private Long sleepNanos;
Expand All @@ -55,3 +56,4 @@ public void declareOutputFields(OutputFieldsDeclarer declarer) {

}
}

Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
import org.apache.storm.tuple.Values;

public class IdBolt extends BaseRichBolt {
private static final long serialVersionUID = 8578055825211897856L;
private OutputCollector collector;

@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
import org.apache.storm.tuple.Tuple;

public class IdentityBolt extends BaseRichBolt {
private static final long serialVersionUID = 7556207705817740527L;
private OutputCollector collector;

@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
* NOTE: Prefer to use the built-in JoinBolt wherever applicable
*/
public class SingleJoinBolt extends BaseRichBolt {
private static final long serialVersionUID = 2986304714244016387L;
OutputCollector collector;
Fields idFields;
Fields outFields;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@

public class DynamicStatementBuilder implements Serializable {

private static final long serialVersionUID = 4417334935956874165L;

private DynamicStatementBuilder() {
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
import org.slf4j.LoggerFactory;

public class BatchCassandraWriterBolt extends BaseCassandraBolt<List<Tuple>> {

private static final long serialVersionUID = 3874909124472122932L;
public static final int DEFAULT_EMIT_FREQUENCY = 2;
private static final Logger LOG = LoggerFactory.getLogger(BatchCassandraWriterBolt.class);
private LinkedBlockingQueue<Tuple> queue;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
import org.apache.storm.tuple.Tuple;

public class CassandraWriterBolt extends BaseCassandraBolt<Tuple> {

private static final long serialVersionUID = 5043125450713195041L;
private AsyncResultHandler<Tuple> asyncResultHandler;

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
* Configuration used by cassandra storm components.
*/
public class CassandraConf implements Serializable {

private static final long serialVersionUID = -297312399366194518L;
public static final String CASSANDRA_USERNAME = "cassandra.username";
public static final String CASSANDRA_PASSWORD = "cassandra.password";
public static final String CASSANDRA_KEYSPACE = "cassandra.keyspace";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
public class DefaultClient implements SimpleClient, Closeable, Serializable {

private static final Logger LOG = LoggerFactory.getLogger(DefaultClient.class);
private static final long serialVersionUID = -5197633787983669015L;

private String keyspace;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
* </p>
*/
public class ObjectMapperCqlStatementMapperBuilder implements CQLStatementBuilder<ObjectMapperCqlStatementMapper>, Serializable {
private static final long serialVersionUID = 7678503881511207283L;
private final String operationField;
private final String valueField;
private final Collection<Class<?>> udtClasses = new ArrayList<>();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
@SuppressWarnings("checkstyle:AbbreviationAsWordInName")
public class SimpleCQLStatementMapperBuilder implements CQLStatementBuilder<SimpleCQLStatementMapper>, Serializable {

private static final long serialVersionUID = 7042291088422917602L;
private final String queryString;

private CqlMapper mapper;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
* Basic bolt for storing tuple to ES document.
*/
public class EsIndexBolt extends AbstractEsBolt {
private static final long serialVersionUID = -7642077255818586463L;
private final EsTupleMapper tupleMapper;

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@
*/
public class EsLookupBolt extends AbstractEsBolt {

private static final long serialVersionUID = -5863240030393506846L;
private final EsTupleMapper tupleMapper;
private final EsLookupResultOutput output;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@
*/
public class EsPercolateBolt extends AbstractEsBolt {

private static final long serialVersionUID = 8103823842646188246L;
private final EsTupleMapper tupleMapper;

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
*/
public final class StormElasticSearchClient implements Serializable {

private static final long serialVersionUID = -3910184447842451527L;
private final EsConfig esConfig;

public StormElasticSearchClient(EsConfig esConfig) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,7 @@
*/
public class EventHubBolt extends BaseRichBolt {
private static final long serialVersionUID = 1L;
private static final Logger logger = LoggerFactory
.getLogger(EventHubBolt.class);
private static final Logger logger = LoggerFactory.getLogger(EventHubBolt.class);

protected OutputCollector collector;
protected PartitionSender sender;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@
import org.apache.storm.eventhubs.spout.SimplePartitionManager;

public class AtMostOnceEventCount extends EventCount implements Serializable {
private static final long serialVersionUID = 2276482213939453480L;

public static void main(String[] args) throws Exception {
AtMostOnceEventCount scenario = new AtMostOnceEventCount();

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
*/
@SuppressWarnings("checkstyle:AbbreviationAsWordInName")
public class HBaseBolt extends AbstractHBaseBolt {
private static final long serialVersionUID = 2138011224544163322L;
private static final Logger LOG = LoggerFactory.getLogger(HBaseBolt.class);
private static final int DEFAULT_FLUSH_INTERVAL_SECS = 1;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
* <p>Note: Each HBaseBolt defined in a topology is tied to a specific table.
*/
public class HBaseLookupBolt extends AbstractHBaseBolt {
private static final long serialVersionUID = -8206079974670011700L;
private static final Logger LOG = LoggerFactory.getLogger(HBaseLookupBolt.class);

private HBaseValueMapper rowToTupleMapper;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ public void multiPut(List<List<Object>> keys, List<T> values) {
}

public static class Options<T> implements Serializable {

private static final long serialVersionUID = -6513148451415208612L;
public Serializer<T> serializer = null;
public int cacheSize = 5000;
public String globalKey = "$HBASE_STATE_GLOBAL$";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
import org.slf4j.LoggerFactory;

public class AvroGenericRecordBolt extends AbstractHdfsBolt {

private static final long serialVersionUID = 3426992477471290298L;
private static final Logger LOG = LoggerFactory.getLogger(AvroGenericRecordBolt.class);

public AvroGenericRecordBolt withFsUrl(String fsUrl) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
import org.slf4j.LoggerFactory;

public class HdfsBolt extends AbstractHdfsBolt {
private static final long serialVersionUID = 8732488717499902331L;
private static final Logger LOG = LoggerFactory.getLogger(HdfsBolt.class);

private transient FSDataOutputStream out;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@
import org.slf4j.LoggerFactory;

public class HiveBolt extends BaseRichBolt {
private static final long serialVersionUID = -8477018696751233324L;
private static final Logger LOG = LoggerFactory.getLogger(HiveBolt.class);
@VisibleForTesting
Map<HiveEndPoint, HiveWriter> allWriters;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
* Note: Each JdbcInsertBolt defined in a topology is tied to a specific table.
*/
public class JdbcInsertBolt extends AbstractJdbcBolt {
private static final long serialVersionUID = -2719870314706220578L;
private static final Logger LOG = LoggerFactory.getLogger(JdbcInsertBolt.class);

private String tableName;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
* Basic bolt for querying from any database.
*/
public class JdbcLookupBolt extends AbstractJdbcBolt {
private static final long serialVersionUID = 7695955541005384059L;
private static final Logger LOG = LoggerFactory.getLogger(JdbcLookupBolt.class);

private String selectQuery;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@ public List<List<Values>> batchRetrieve(List<TridentTuple> tridentTuples) {
}

public static class Options implements Serializable {
private static final long serialVersionUID = -1642655048655000396L;
private JdbcMapper mapper;
private JdbcLookupMapper jdbcLookupMapper;
private ConnectionProvider connectionProvider;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@
* it does not emit any tuples.
*/
public class JmsBolt extends BaseTickTupleAwareRichBolt {
private static final long serialVersionUID = -6203834510835411472L;
private static Logger LOG = LoggerFactory.getLogger(JmsBolt.class);

private boolean autoAck = true;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@ public void updateState(List<TridentTuple> tuples, TridentCollector collector) t
}

public static class Options implements Serializable {
private static final long serialVersionUID = 8022017182667431203L;
private JmsProvider jmsProvider;
private JmsMessageProducer msgProducer;
private int jmsAcknowledgeMode = Session.AUTO_ACKNOWLEDGE;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,8 @@ public class KafkaSpoutRetryExponentialBackoff implements KafkaSpoutRetryService
* Comparator ordering by timestamp.
*/
private static class RetryEntryTimeStampComparator implements Serializable, Comparator<RetrySchedule> {
private static final long serialVersionUID = -4964614653561591552L;

@Override
public int compare(RetrySchedule entry1, RetrySchedule entry2) {
int result = Long.valueOf(entry1.nextRetryTimeNanos()).compareTo(entry2.nextRetryTimeNanos());
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ public class KafkaTridentSpoutCoordinator<K,V> implements
IOpaquePartitionedTridentSpout.Coordinator<List<Map<String, Object>>>,
IPartitionedTridentSpout.Coordinator<List<Map<String, Object>>>,
Serializable {
private static final long serialVersionUID = 831108958500512737L;
//Initial delay for the assignment refresh timer
public static final long TIMER_DELAY_MS = 500;
private static final Logger LOG = LoggerFactory.getLogger(KafkaTridentSpoutCoordinator.class);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
* {@link ISpoutPartition} that wraps {@link TopicPartition} information.
*/
public class KafkaTridentSpoutTopicPartition implements ISpoutPartition, Serializable {
private static final long serialVersionUID = -4695977965301783511L;
private final TopicPartition topicPartition;

public KafkaTridentSpoutTopicPartition(String topic, int partition) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
import java.util.Date;

public class KinesisConfig implements Serializable {
private static final long serialVersionUID = -2660946324365967869L;
// kinesis stream name to read from
private final String streamName;
// shard iterator type based on kinesis api - beginning of time, latest, at timestamp are only supported
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
import org.objenesis.strategy.StdInstantiatorStrategy;

public class KinesisConnectionInfo implements Serializable {
private static final long serialVersionUID = 8799748040190430626L;
private final byte[] serializedKinesisCredsProvider;
private final byte[] serializedkinesisClientConfig;
private final Integer recordsLimit;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@

public class TestRecordToTupleMapper implements RecordToTupleMapper, Serializable {
private static final Logger LOG = LoggerFactory.getLogger(TestRecordToTupleMapper.class);
private static final long serialVersionUID = -8825697100165763982L;

@Override
public Fields getOutputFields() {
return new Fields("partitionKey", "sequenceNumber", "data");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
* Note: Each MongoInsertBolt defined in a topology is tied to a specific collection.
*/
public class MongoInsertBolt extends AbstractMongoBolt {

private static final long serialVersionUID = 5181213261367939689L;
private static final int DEFAULT_FLUSH_INTERVAL_SECS = 1;

private MongoMapper mapper;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
* Note: Each MongoLookupBolt defined in a topology is tied to a specific collection.
*/
public class MongoLookupBolt extends AbstractMongoBolt {

private static final long serialVersionUID = -5170877102054804819L;
private QueryFilterCreator queryCreator;
private MongoLookupMapper mapper;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
* Note: Each MongoUpdateBolt defined in a topology is tied to a specific collection.
*/
public class MongoUpdateBolt extends AbstractMongoBolt {

private static final long serialVersionUID = -5520612633851250677L;
private QueryFilterCreator queryCreator;
private MongoUpdateMapper mapper;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ protected MongoMapState(Map<String, Object> map, Options options) {
}

public static class Options<T> implements Serializable {
private static final long serialVersionUID = 3252817063788089651L;
public String url;
public String collectionName;
public MongoMapper mapper;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ protected MongoState(Map<String, Object> map, Options options) {
}

public static class Options implements Serializable {
private static final long serialVersionUID = 241563415043284544L;
private String url;
private String collectionName;
private MongoMapper mapper;
Expand Down
Loading

0 comments on commit b700a24

Please sign in to comment.