Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-51048][CORE] Support stop java spark context with exit code #49746

Closed
wants to merge 5 commits into from
Closed

[SPARK-51048][CORE] Support stop java spark context with exit code #49746

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9c24ba9
SPARK-51048 | Support stop java spark context with exit code
prathit06 Jan 31, 2025
bab84b8
SPARK-51048 | Support stop java spark context with exit code
prathit06 Feb 3, 2025
b500324
SPARK-51048 | Support stop java spark context with exit code
prathit06 Feb 3, 2025
68d4c33
SPARK-51048 | Support stop java spark context with exit code
prathit06 Feb 3, 2025
2cce3c3
SPARK-51048 | updated javadoc
prathit06 Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions core/src/main/scala/org/apache/spark/api/java/JavaSparkContext.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -552,6 +552,11 @@ class JavaSparkContext(val sc: SparkContext) extends Closeable {
sc.stop()
}

/** Shut down the SparkContext with exit code. */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add the JavaDoc?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, please re-review

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can copy and paste from Scala's one ..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done @HyukjinKwon , please re-review. Test case failing seems to be unrelated

def stop(exitCode: Int): Unit = {
sc.stop(exitCode)
}

override def close(): Unit = stop()

/**
Expand Down