Configure operator logging in helm chart #779
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is no impetus for a v1.0 right now, so I don't think there would be an issue doing this in v0.10.0 |
gerlowskija
reviewed
Apr 3, 2025
helm/solr-operator/README.md
Outdated
| @@ -191,6 +191,10 @@ The command removes all the Kubernetes components associated with the chart and | |||
| | tolerations | []object | | Specify a list of Kubernetes tolerations for the Solr Operator pod | | |||
| | priorityClassName | string | `""` | Give a priorityClassName for the Solr Operator pod | | |||
| | sidecarContainers | []object | | An optional list of additional containers to run along side the Solr Operator in its pod | | |||
| | logger.devel | boolean | `false` | Enable development mode for the Solr Operator logger. This will log at the debug level with the console encoder. Default is `false` which logs at `info` level with `json` encoder. | | |||
There was a problem hiding this comment.
[0] I could see the dev/prod distinction being useful for setting defaults totally unrelated to logging (docker image tag, resource limits, etc.). Wdyt about moving this "mode" flag up to the top level, so it's easier to expand later to cover other things if desired?
There was a problem hiding this comment.
Good idea. I promoted it to top level development, which can then be used elsewhere later.
Co-authored-by: Jason Gerlowski <[email protected]>
# Conflicts: # helm/solr-operator/Chart.yaml
…o feature/helm-logging-config # Conflicts: # helm/solr-operator/Chart.yaml
|
I added some docs
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds this to
values.yaml:Docs:
Note that today zap "Development" mode has been the default, but this PR changes that to
false, triggering production mode by default, and thus also log-level INFO and encoding to JSON. This is perhaps a bit much change in a minor version even if it is easy for users to tailor it. At the same time it feels wrong that development is the default mode. We could keep the default of development=true and change it to false in v1.0?Fixes #778