Fix unset-var bug in 'verify_all.sh' script (#749)

A variable 'artifact' was being referenced outside of the for-in loop that created it. Fixes that bug.
apache · Jan 23, 2025 · 47446f0 · 47446f0
1 parent 8d46989
commit 47446f0
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/hack/release/smoke_test/verify_all.sh b/hack/release/smoke_test/verify_all.sh
@@ -112,12 +112,11 @@ echo "Download all artifacts and verify signatures"
           gpg --verify "${artifact}.asc" "${artifact}" \
             || { echo "Invalid signature for ${artifact}. Aborting!"; exit 1; }
         fi
+        # If a helm chart has a provenance file, and a GPG Key was provided, then verify the provenance file
+        if [[ -f "${artifact}.prov" && -n "${GPG_KEY:-}" ]]; then
+          helm verify "${artifact}"
+        fi
       done
-
-      # If a helm chart has a provenance file, and a GPG Key was provided, then verify the provenance file
-      if [[ -f "${artifact}.prov" && -n "${GPG_KEY:-}" ]]; then
-        helm verify "${artifact}"
-      fi
     )
   done