Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/linux fadvis and typo fix #619

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Eternity1824
Copy link

Fix

  • Bug Fix: Corrected a typo in merger.go (reserveSpace) by updating the variable correctly:
    needSize += parts[i].p.partMetadata.CompressedSizeBytes
    
    

  • New Feature: Implement Linux-specific fadvis functionality to prevent big files from polluting the OS page cache.

•Temporary Workaround: Set the large file threshold to 128MB as a temporary measure for the issue.
•This pull request fixes [BanyanDB-Server] Big Files Should Not Pollute OS Page Cache #12448.

  • If this pull request closes/resolves/fixes an existing issue, replace the issue number. Fixes apache/skywalking#.
  • Update the CHANGES log.

@wu-sheng wu-sheng added this to the 0.8.0 milestone Mar 10, 2025
@wu-sheng wu-sheng requested a review from hanahmily March 10, 2025 10:04
@hanahmily
Copy link
Contributor

@Eternity1824 The current design is too far from our target; let’s schedule a meeting to discuss it.

@wu-sheng wu-sheng removed this from the 0.8.0 milestone Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants