Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-JIRA: Travis CI update: #1510

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

kgiusti
Copy link
Contributor

@kgiusti kgiusti commented Feb 5, 2022

  • remove MacOS
  • remove test configurations already covered by Github Actions
  • All tests run either TSAN or ASAN checkers
  • whitespace fixups

 - remove MacOS
 - remove test configurations already covered by Github Actions
 - All tests run either TSAN or ASAN checkers
 - whitespace fixups
@codecov-commenter
Copy link

Codecov Report

Merging #1510 (94b3671) into main (6d03790) will decrease coverage by 1.51%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1510      +/-   ##
==========================================
- Coverage   84.94%   83.42%   -1.52%     
==========================================
  Files         116      118       +2     
  Lines       28640    30084    +1444     
==========================================
+ Hits        24327    25097     +770     
- Misses       4313     4987     +674     
Impacted Files Coverage Δ
include/qpid/dispatch/ctools.h 61.11% <0.00%> (-8.89%) ⬇️
tests/tool_test.c 77.14% <0.00%> (-7.70%) ⬇️
...router_core/modules/edge_router/link_route_proxy.c 75.41% <0.00%> (-7.43%) ⬇️
include/qpid/dispatch/buffer.h 94.73% <0.00%> (-5.27%) ⬇️
src/python_utils.c 83.33% <0.00%> (-3.04%) ⬇️
src/connection_manager.c 86.04% <0.00%> (-3.01%) ⬇️
router/src/main.c 67.30% <0.00%> (-2.70%) ⬇️
...uter_core/modules/edge_router/connection_manager.c 94.28% <0.00%> (-2.59%) ⬇️
src/entity.c 58.01% <0.00%> (-2.42%) ⬇️
tests/proton_utils_tests.c 72.72% <0.00%> (-2.28%) ⬇️
... and 99 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d03790...94b3671. Read the comment docs.

@jiridanek
Copy link
Contributor

Maybe also disable python-checker on Travis. This is source code linter, not really too much related to platform on which it is being run. And, it fails on Travis. I could do that in subsequent PR, of course.

@kgiusti kgiusti added this to the 1.20.0 milestone Feb 16, 2022
@kgiusti kgiusti marked this pull request as draft February 16, 2022 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants