Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Group application.properties by build time / run time #970

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Group application.properties by build time / run time #970

wants to merge 1 commit into from

Conversation

dimas-b
Copy link
Contributor

@dimas-b dimas-b commented Feb 8, 2025

As discussed in latest community meeting, having proprties that are settable only at build time can be surprising to Polaris users and contributors.

This change attempts to help with that matter by grouping build time properties into dedicated sections inside application.properties files and adding comments to clarify their usage.

@dimas-b
Group application.properties by build time / run time
d122208 
As discussed in latest community meeting, having proprties
that are settable only at build time can be surprising to
Polaris users and contributors.

This change attempts to help with that matter by grouping
build time properties into dedicated sections inside
application.properties files and adding comments to clarify
their usage.
@dimas-b dimas-b mentioned this pull request Feb 8, 2025
Merged
flyrain
flyrain approved these changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@flyrain flyrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this. One minor suggestion: can we move runtime configuration on the top of the build-time ones. Certain users may only care about the runtime configs, also build-time configs changes less frequently than runtime ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adutra adutra adutra approved these changes

@flyrain flyrain flyrain approved these changes

@ashvina ashvina Awaiting requested review from ashvina ashvina is a code owner

@dennishuo dennishuo Awaiting requested review from dennishuo dennishuo is a code owner

@eric-maynard eric-maynard Awaiting requested review from eric-maynard eric-maynard is a code owner

@jackye1995 jackye1995 Awaiting requested review from jackye1995 jackye1995 is a code owner

@jbonofre jbonofre Awaiting requested review from jbonofre jbonofre is a code owner

@vvcephei vvcephei Awaiting requested review from vvcephei vvcephei is a code owner

@collado-mike collado-mike Awaiting requested review from collado-mike collado-mike is a code owner

@snazy snazy Awaiting requested review from snazy snazy is a code owner

@RussellSpitzer RussellSpitzer Awaiting requested review from RussellSpitzer RussellSpitzer is a code owner

@takidau takidau Awaiting requested review from takidau takidau is a code owner

@MonkeyCanCode MonkeyCanCode Awaiting requested review from MonkeyCanCode MonkeyCanCode is a code owner

@ebyhr ebyhr Awaiting requested review from ebyhr ebyhr is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dimas-b @adutra @flyrain