-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add label to easily filter renovatebot PR notifications #839
base: main
Are you sure you want to change the base?
Conversation
The label is an awesome idea. Can we perhaps make it less frequent than daily? We can always manually update a dependency if there's an urgent need, but otherwise I think ~weekly automated upgrades should be sufficient. |
Full agree. It's not just the e-mail noise, but the commit history is noisy too. Renovate has merged ~25 commits in just the last week. I think it's important for PR queues and commit history to be easily scannable by humans to find important changes. Otherwise, we just get used to a pile of unimportant notifications and just start ignoring things |
Following our discussion, I updated this PR:
|
I'm fine with the label. However, I'm strongly in favor of not grouping all updates into a single PR, nor to change the schedule. In practice it happens quite often that a single dependency change requires additional changes (spotless formatting, API changes in dependencies, etc). Applying those changes to a huge "once a week bump 50 dependencies" PR is not helpful either. It also adds a lot of burden to those who curate those renovate-PRs and for those to review those updated renovate-PRs. That becomes even more difficult with grouped dependencies that affect different parts of the code base. Grouping multiple version bumps together also makes a later |
I'd be happy to compromise on grouping (the git bisect use case is totally valid) if we can at least schedule the updates to happen on the same day each week. That will, ideally, group all the renovate PRs together so that human activity can be easily scanned in the commit history and open PRs. |
I'd rather prefer to update the really noisy dependencies to weekly, like #900. |
Wdyt about adding package rule to schedule some frequent update every week and leave the rest as it is ? |
No, I don't changing the schedule for specific dependencies will be sufficient. Renovate is far too noisy right now -- it filed 3 PRs yesterday. Once a week without grouping might be OK, but I would still prefer grouping. If grouping makes upgrading dependencies more difficult, I think it's fine to simply upgrade dependencies less often or on an as-needed basis. |
3 PRs a day is not too noisy IMHO, especially for a fresh project ;) |
I would propose then to not group and do weekly PRs. As renovatebot is now calming down 😄 I think it's a good consensus. Thoughts ? |
…ot PR notifications)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for driving this @jbonofre !
Wait, the PR doesn't currently implement weekly PRs, right? Is that going to be a followup PR? |
This PR proposes:
renovatebot
label to easily filter PRs and emails