Update the segment operation throttle defaults to Integer.MAX_VALUE #15126
+55
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Quickstart test failures seem to be happening for other PRs as well, so it is unrelated to this change e.g. failed run from another PR: https://github.com/apache/pinot/actions/runs/13529893668 |
klsince
reviewed
Feb 25, 2025
...local/src/test/java/org/apache/pinot/segment/local/utils/SegmentOperationsThrottlerTest.java
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #15126 +/- ##
============================================
+ Coverage 61.75% 63.44% +1.69%
- Complexity 207 1482 +1275
============================================
Files 2436 2748 +312
Lines 133233 154445 +21212
Branches 20636 23816 +3180
============================================
+ Hits 82274 97993 +15719
- Misses 44911 49059 +4148
- Partials 6048 7393 +1345
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
klsince
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the segment operation throttle defaults to Integer.MAX_VALUE. Setting the default to this is more effective in disabling throttling for scenarios where max.parallel.refresh.threads and STATE_TRANSITION.maxThreads may be higher than the older default of 100. Update tests.