Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use multiple threads to merge distinct_count result on server #15111

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Jackie-Jiang
Copy link
Contributor

No description provided.

@Jackie-Jiang Jackie-Jiang force-pushed the multi_thread_distinct_count branch 2 times, most recently from 817c15b to 45a9462 Compare February 24, 2025 04:03
@Jackie-Jiang Jackie-Jiang force-pushed the multi_thread_distinct_count branch from 45a9462 to 6ceaf44 Compare February 24, 2025 04:04
@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2025

Codecov Report

Attention: Patch coverage is 67.10526% with 25 lines in your changes missing coverage. Please review.

Project coverage is 63.41%. Comparing base (59551e4) to head (6ceaf44).
Report is 1753 commits behind head on master.

Files with missing lines Patch % Lines
...e/operator/combine/AggregationCombineOperator.java 67.12% 14 Missing and 10 partials ⚠️
...org/apache/pinot/core/common/ObjectSerDeUtils.java 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #15111      +/-   ##
============================================
+ Coverage     61.75%   63.41%   +1.66%     
- Complexity      207     1482    +1275     
============================================
  Files          2436     2745     +309     
  Lines        133233   154384   +21151     
  Branches      20636    23823    +3187     
============================================
+ Hits          82274    97902   +15628     
- Misses        44911    49080    +4169     
- Partials       6048     7402    +1354     
Flag Coverage Δ
custom-integration1 100.00% <ø> (+99.99%) ⬆️
integration 100.00% <ø> (+99.99%) ⬆️
integration1 100.00% <ø> (+99.99%) ⬆️
integration2 0.00% <ø> (ø)
java-11 63.39% <67.10%> (+1.68%) ⬆️
java-21 63.31% <67.10%> (+1.68%) ⬆️
skip-bytebuffers-false 63.41% <67.10%> (+1.66%) ⬆️
skip-bytebuffers-true 63.29% <67.10%> (+35.56%) ⬆️
temurin 63.41% <67.10%> (+1.66%) ⬆️
unittests 63.41% <67.10%> (+1.66%) ⬆️
unittests1 56.05% <67.10%> (+9.16%) ⬆️
unittests2 33.93% <0.00%> (+6.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants