Upgrade beanshell library #15108
Open
Upgrade beanshell library #15108
+16
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #15108 +/- ##
============================================
+ Coverage 61.75% 63.42% +1.67%
- Complexity 207 1483 +1276
============================================
Files 2436 2745 +309
Lines 133233 154311 +21078
Branches 20636 23807 +3171
============================================
+ Hits 82274 97878 +15604
- Misses 44911 49044 +4133
- Partials 6048 7389 +1341
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
abhioncbr
approved these changes
Feb 22, 2025
Comment on lines
+2059
to
+2064
| <exclusions> | ||
| <exclusion> | ||
| <groupId>org.beanshell</groupId> | ||
| <artifactId>bsh</artifactId> | ||
| </exclusion> | ||
| </exclusions> |
There was a problem hiding this comment.
Since we added the explicit dependency, this shouldn't be required
Comment on lines
+294
to
+297
| <dependency> | ||
| <groupId>org.apache-extras.beanshell</groupId> | ||
| <artifactId>bsh</artifactId> | ||
| </dependency> |
There was a problem hiding this comment.
This shouldn't be required either
| </exclusion> | ||
| </exclusions> | ||
| </dependency> | ||
| <dependency> |
There was a problem hiding this comment.
Suggest adding a comment stating this is used in fmpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade beanshell package from org.beanshell:bsh:2.0b4 to org.apache-extras.beanshell:bsh:2.0b6