Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Avg BigDecimal #15101

Open
wants to merge 328 commits into
base: master
Choose a base branch
from

Conversation

zeronerdzerogeekzerocool
Copy link
Contributor

Instructions:

  1. The PR has to be tagged with at least one of the following labels (*):
    1. feature
    2. bugfix
    3. performance
    4. ui
    5. backward-incompat
    6. release-notes (**)
  2. Remove these instructions before publishing the PR.

(*) Other labels to consider:

  • testing
  • dependencies
  • docker
  • kubernetes
  • observability
  • security
  • code-style
  • extension-point
  • refactor
  • cleanup

(**) Use release-notes label for scenarios like:

  • New configuration options
  • Deprecation of configurations
  • Signature changes to public methods/interfaces
  • New plugins added or old plugins removed

dependabot bot and others added 29 commits February 20, 2025 15:03
…pache#14716)

* Fix false data loss alerts in case of read_committed Kafka isolation

* Fix null handling

---------

Co-authored-by: Kartik Khare <[email protected]>
Bumps software.amazon.awssdk:bom from 2.29.40 to 2.29.41.

---
updated-dependencies:
- dependency-name: software.amazon.awssdk:bom
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…afety issue in the JDBC client (apache#14723)

Use DateTimeFormatter instead of SimpleDateFormat to resolve thread safety issue in the JDBC client
…14728)

Bumps [com.puppycrawl.tools:checkstyle](https://github.com/checkstyle/checkstyle) from 10.21.0 to 10.21.1.
- [Release notes](https://github.com/checkstyle/checkstyle/releases)
- [Commits](checkstyle/checkstyle@checkstyle-10.21.0...checkstyle-10.21.1)

---
updated-dependencies:
- dependency-name: com.puppycrawl.tools:checkstyle
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps software.amazon.awssdk:bom from 2.29.41 to 2.29.43.

---
updated-dependencies:
- dependency-name: software.amazon.awssdk:bom
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…pache#14738)

* Avoid handling JSON_ARRAY as multi value JSON during transformation

* Revert "Avoid handling JSON_ARRAY as multi value JSON during transformation"

This reverts commit 289b433.

* handle empty JSON array during transformation

* cosmetic
rajagopr and others added 26 commits February 20, 2025 15:03
…apache#15070)

* Emits metric before postStopConsumedMsg

* changes type to throwable
…e#15065)

* Releases partitionGroupConsumerSemaphore incase of Errors

* Adds check to ignore committing segments as completed

* nit

* inverse

* Adds code comment
…mmary of the dry-run results (apache#15050)

* Add a dry-run summary mode for TableRebalance which only returns a summary of the dry-run results

* Address review - add server level lists of added, removed, unchanged, and servers getting new segments
* Adding support to allow passing null server metrics while building segment. This is added for reingestion that should not impact the normal server metrics

* Releasing sempahore to prevent deadlock from happening while segments are reingested and built

* Fixing integration tests to catch the case of deadlock caused by not releasing the build semaphore
# Conflicts:
#	pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/AggregationFunctionType.java
@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2025

Codecov Report

Attention: Patch coverage is 0% with 176 lines in your changes missing coverage. Please review.

Project coverage is 33.92%. Comparing base (59551e4) to head (e61c285).
Report is 1746 commits behind head on master.

Files with missing lines Patch % Lines
...tion/function/AvgPrecisionAggregationFunction.java 0.00% 134 Missing ⚠️
...e/pinot/segment/local/customobject/AvgBigPair.java 0.00% 34 Missing ⚠️
...org/apache/pinot/core/common/ObjectSerDeUtils.java 0.00% 4 Missing ⚠️
...che/pinot/segment/spi/AggregationFunctionType.java 0.00% 3 Missing ⚠️
...gregation/function/AggregationFunctionFactory.java 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (59551e4) and HEAD (e61c285). Click for more details.

HEAD has 6 uploads less than BASE
Flag BASE (59551e4) HEAD (e61c285)
skip-bytebuffers-false 7 6
unittests 5 3
unittests1 2 0
java-11 5 4
Additional details and impacted files
@@              Coverage Diff              @@
##             master   #15101       +/-   ##
=============================================
- Coverage     61.75%   33.92%   -27.84%     
- Complexity      207      686      +479     
=============================================
  Files          2436     2748      +312     
  Lines        133233   154497    +21264     
  Branches      20636    23848     +3212     
=============================================
- Hits          82274    52408    -29866     
- Misses        44911    97850    +52939     
+ Partials       6048     4239     -1809     
Flag Coverage Δ
custom-integration1 100.00% <ø> (+99.99%) ⬆️
integration 100.00% <ø> (+99.99%) ⬆️
integration1 100.00% <ø> (+99.99%) ⬆️
integration2 0.00% <ø> (ø)
java-11 33.90% <0.00%> (-27.80%) ⬇️
java-21 33.91% <0.00%> (-27.71%) ⬇️
skip-bytebuffers-false 33.91% <0.00%> (-27.83%) ⬇️
skip-bytebuffers-true 33.91% <0.00%> (+6.18%) ⬆️
temurin 33.92% <0.00%> (-27.84%) ⬇️
unittests 33.91% <0.00%> (-27.83%) ⬇️
unittests1 ?
unittests2 33.91% <0.00%> (+6.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.