[kinesis] Disabled testGetStreamNamesWithPagination on CI due to cost #15085
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cost The createStream() call in this test is incurring recurring costs in CI. The test is retained for manual use. Note that the test only runs when AWS secrets are loaded in the env
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #15085 +/- ##
============================================
+ Coverage 61.75% 63.38% +1.63%
- Complexity 207 1480 +1273
============================================
Files 2436 2741 +305
Lines 133233 154028 +20795
Branches 20636 23778 +3142
============================================
+ Hits 82274 97630 +15356
- Misses 44911 49013 +4102
- Partials 6048 7385 +1337
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
xiangfu0
approved these changes
Feb 20, 2025
Jackie-Jiang
approved these changes
Feb 23, 2025
| @@ -112,7 +112,7 @@ public void testGetStreamNames() { | |||
| "Expected to find test stream " + _testStreamName + " in list of streams: " + streams); | |||
| } | |||
|
|
|||
| @Test(dependsOnMethods = "testGetStreamNames") | |||
| @Test(dependsOnMethods = "testGetStreamNames", enabled = false) | |||
There was a problem hiding this comment.
Let's add some description on why this test is disabled by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The createStream() call in this test is incurring recurring costs in CI. The test is retained for manual use.
Note that the test only runs when AWS secrets are loaded in the env.