NUTCH-3013 Employ commons-lang3's StopWatch to simplify timing logic #788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge lewismc:master with apache:master
merge lewismc:master with apache:master
merge lewismc:master with apache:master
merge lewismc:master with apache:master
sebastian-nagel
approved these changes
Oct 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses https://issues.apache.org/jira/browse/NUTCH-3013
If this gets merged I'll squash all of those commits.
Note, this does change the logging slightly. The whole
LOG.info("CrawlDb update: starting at {}", sdf.format(start));is redundant because we already capture the datetime stamp in the log output anyway.I simplified this to
LOG.info("CrawlDb update: starting");.Passes local unit tests.