Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added sonarcloud badge #745

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added sonarcloud badge #745

wants to merge 1 commit into from

Conversation

nikcio
Copy link
Contributor

@nikcio nikcio commented Nov 5, 2022 •
edited
Loading

Added a sonar cloud badge to the README to easily link the project sonar cloud page. This also helps convey the rated maintainability of the project.

Looks:
image

@NightOwl888
Copy link
Contributor

Thanks. This will make a great addition, except I think we should hold off on merging it until after we have:

  1. Updated the CONTRIBUTING.md page to inform contributors not to submit PRs for random things out of the scan that we haven't decided whether or not we will fix.
  2. Added a PR template indicating that only approved issues from SonarCloud will be accepted (approved being that they have been made into a GitHub issue). The PR templates would also allow us to put other guardrails in place so we don't have to reject PRs for people who were just trying to help out, but submitted something we cannot use in this version of Lucene.NET.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nikcio @NightOwl888