Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP to fix #308
The first part is that this fixes a deadlock issues with MockDirectoryWrapper.
this
which seems common from the java port. This wasn't the problem but lock (this) shouldn't be used since there is no way of knowing if something else is locking on that object which will cause deadlocks. This has been changed to lock on a private field. I have verified that there is no other code that ever locks on a directory object so there was nothing important about locking onthis
.There's currently a temp test in this code which allows to run the slow running test over and over until it runs for longer than the specified time. With the deadlock fixed I think i can now see where the slowness of the method comes from so will now look into profiling this.