MINOR: Improve error logging for task commit failures #19326
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enhances the error messages logged during task commit failures by including the specific cause from the `TimeoutException`. This provides clearer context to debug issues related to timeout errors.
mjsax
reviewed
Mar 31, 2025
| offsetsPerTask | ||
| .keySet() | ||
| .stream() | ||
| .map(t -> t.id().toString()) | ||
| .collect(Collectors.joining(", "))), | ||
| .collect(Collectors.joining(", ")), timeoutException.getMessage()), | ||
| timeoutException |
There was a problem hiding this comment.
Not sure if I understand this change. Given that we pass timeoutException as second parameter into log.error(...) we should get the corresponding error message logged already?
if a user removes stack traces from the logging,
Not sure what this means?
There was a problem hiding this comment.
Nit: formatting:
log.error(
String.format(
"Committing task(s) %s failed due to %s",
offsetsPerTask
.keySet()
.stream()
.map(t -> t.id().toString())
.collect(Collectors.joining(", ")),
timeoutException.getMessage()
),
timeoutException
);
timeoutException
There was a problem hiding this comment.
Yes, we pass timeoutException but If users truncate the stack trace that information is lost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhances the error messages logged during task commit failures by including the specific cause from the
TimeoutException. This provides clearer context to debug issues related to timeout errors.While we provide the exception object to the
log.errormethod, if a user removes stack traces from the logging, then we are left with the messageCommitting failed. By adding theException.getMessage()we'll gain a little more insight in these instances.All existing tests passed locally