KAFKA-19055: Cleanup the 0.10.x information from clients module #19320
Conversation
| @@ -24,7 +24,7 @@ | |||
| * <p> | |||
| * <h4>Clients</h4> | |||
| * There will be one invocation of {@link ClusterResourceListener#onUpdate(ClusterResource)} after each metadata response. | |||
| * Note that the cluster id may be null when the Kafka broker version is below 0.10.1.0. If you receive a null cluster id, you can expect it to always be null unless you have a cluster with multiple broker versions which can happen if the cluster is being upgraded while the client is running. | |||
| * Note the minimum supported broker version is 2.1. If you receive a null cluster id, you can expect it to always be null unless you have a cluster with multiple broker versions which can happen if the cluster is being upgraded while the client is running. | |||
There was a problem hiding this comment.
It is impossible to have "null" cluster id for now, right?
There was a problem hiding this comment.
It is impossible to have "null" cluster id for now, right?
I will remove the outdated part.
There was a problem hiding this comment.
Not sure whether we can also remove these lines if we drop support for version below 2.1?
kafka/clients/src/main/java/org/apache/kafka/common/config/TopicConfig.java
Lines 110 to 111 in 6f4d425
|
yes, please revise it as well. Also, please add this changes to the PR description. |
Removes outdated references to Kafka 0.10.x in the clients module documentation. Since the baseline version is now 2.1, any mentions of versions earlier than this are unnecessary and have been removed or updated accordingly.
Changes:
ClusterResource,ClusterResourceListener, andDescribeClusterResultJavadoc to reflect the minimum supported broker version as 2.1.TopicConfigdocumentation: Removed references to consumers older than 0.10.2.Testing & Impact:
Reviewers: Chia-Ping Tsai [email protected]