KAFKA-18677: Update ConsoleConsumerTest system test #18763
Merged
+2
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
|
e2e result on my local: |
frankvicky
force-pushed
the
KAFKA-18677
branch
from
65e7451 to
357f0c1
Compare
dajac
reviewed
Jan 31, 2025
| @@ -44,8 +44,7 @@ def setUp(self): | |||
| @cluster(num_nodes=3) | |||
| @matrix(security_protocol=['PLAINTEXT', 'SSL'], metadata_quorum=quorum.all_kraft) | |||
| @cluster(num_nodes=4) | |||
| @matrix(security_protocol=['SASL_SSL'], sasl_mechanism=['PLAIN'], metadata_quorum=quorum.all_kraft) | |||
| @matrix(security_protocol=['SASL_SSL'], sasl_mechanism=['SCRAM-SHA-256', 'SCRAM-SHA-512']) # SCRAM not yet supported with KRaft | |||
| @matrix(security_protocol=['SASL_SSL'], sasl_mechanism=['PLAIN', 'SCRAM-SHA-256', 'SCRAM-SHA-512'], metadata_quorum=quorum.all_kraft) | |||
There was a problem hiding this comment.
While we are here, I wonder if we could directly remove the usage of ZookeeperService in this class. What do you think?
There was a problem hiding this comment.
Sure, I'll give it a try.
There was a problem hiding this comment.
I have just removed the ZookeeperService and run the tests on my local. Here is the result:
JIRA: KAFKA-18677 The ConsoleConsumerTest system test still relied on ZK so it fails. We should convert it to kraft.
frankvicky
force-pushed
the
KAFKA-18677
branch
from
357f0c1 to
15e5a52
Compare
dajac
pushed a commit
that referenced
this pull request
Jan 31, 2025
This patch converts the ConsoleConsumerTest system test to only use KRaft. Reviewers: David Jacot <[email protected]>
|
Merged to trunk and 4.0. Thanks. |
pdruley
pushed a commit
to pdruley/kafka
that referenced
this pull request
Feb 12, 2025
This patch converts the ConsoleConsumerTest system test to only use KRaft. Reviewers: David Jacot <[email protected]>
manoj-mathivanan
pushed a commit
to manoj-mathivanan/kafka
that referenced
this pull request
Feb 19, 2025
This patch converts the ConsoleConsumerTest system test to only use KRaft. Reviewers: David Jacot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: KAFKA-18677
The ConsoleConsumerTest system test still relied on ZK, so it failed.
We should convert it to kraft.
Committer Checklist (excluded from commit message)