-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KAFKA-18576: Convert ConfigType to Enum #18711
base: trunk
Are you sure you want to change the base?
Conversation
aaa6a66
to
cd43ac1
Compare
A label of 'needs-attention' was automatically added to this PR in order to raise the |
f9d27d6
to
818caed
Compare
b77c343
to
a017af3
Compare
A label of 'needs-attention' was automatically added to this PR in order to raise the |
a017af3
to
9a58b41
Compare
A label of 'needs-attention' was automatically added to this PR in order to raise the |
9a58b41
to
9fce39a
Compare
9fce39a
to
abfab57
Compare
A label of 'needs-attention' was automatically added to this PR in order to raise the |
abfab57
to
c980e2f
Compare
A label of 'needs-attention' was automatically added to this PR in order to raise the |
c980e2f
to
e54fc7d
Compare
A label of 'needs-attention' was automatically added to this PR in order to raise the |
e54fc7d
to
66b149e
Compare
A label of 'needs-attention' was automatically added to this PR in order to raise the |
66b149e
to
7ad9f20
Compare
A label of 'needs-attention' was automatically added to this PR in order to raise the |
JIRA: KAFKA-18576 After removing ZooKeeper, we no longer need to exclude `client_metrics` and `group` from `ConfigType#ALL`. Since it's a common pattern to provide a mechanism to know all values in enumeration ( Java enum provides ootb), we should convert ConfigType to enum.
7ad9f20
to
f5dfbec
Compare
A label of 'needs-attention' was automatically added to this PR in order to raise the |
JIRA: KAFKA-18576
After removing ZooKeeper, we no longer need to exclude
client_metrics
andgroup
fromConfigType#ALL
.Since it's a common pattern to provide a mechanism to know all values in enumeration ( Java enum provides ootb), we should convert ConfigType to enum.
Committer Checklist (excluded from commit message)