Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-16907: Fix RaftUtil's type complexity #16831

Open
wants to merge 30 commits into
base: trunk
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 24 commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
2570b83
KAFKA-16907: Resolve the ClassDataAbstractionCoupling and ClassFanOut…
frankvicky Aug 8, 2024
40bca25
KAFKA-16907: Rebase and fix conflicts
frankvicky Aug 9, 2024
b31643b
KAFKA-16907: Rebase and refactor
frankvicky Aug 22, 2024
8736e49
Merge branch 'trunk' into KAFKA-16907
frankvicky Sep 30, 2024
0c898d4
Merge branch 'trunk' into KAFKA-16907
frankvicky Oct 7, 2024
14cd145
Merge branch 'trunk' into KAFKA-16907
frankvicky Oct 7, 2024
88b9072
Merge branch 'trunk' into KAFKA-16907
frankvicky Oct 7, 2024
bdbccf1
Merge branch 'trunk' into KAFKA-16907
frankvicky Oct 8, 2024
21b4b66
Merge branch 'trunk' into KAFKA-16907
frankvicky Oct 21, 2024
8fb5ac0
Merge branch 'trunk' into KAFKA-16907
frankvicky Dec 1, 2024
4896791
Merge branch 'trunk' into KAFKA-16907
frankvicky Dec 18, 2024
8925ff7
KAFKA-16907: Address comments
frankvicky Dec 18, 2024
7e11ea8
Merge branch 'trunk' into KAFKA-16907
frankvicky Dec 29, 2024
5acb0bc
Merge branch 'trunk' into KAFKA-16907
frankvicky Jan 14, 2025
25bff77
KAFKA-16907: reformat
frankvicky Jan 14, 2025
c1b8c79
Merge branch 'trunk' into KAFKA-16907
frankvicky Jan 15, 2025
ca17856
Merge branch 'trunk' into KAFKA-16907
frankvicky Jan 17, 2025
33ce279
Merge branch 'trunk' into KAFKA-16907
frankvicky Jan 21, 2025
f924828
Fix conflicts
frankvicky Jan 21, 2025
c3f25b9
Merge branch 'trunk' into KAFKA-16907
frankvicky Jan 24, 2025
763ef7a
Merge branch 'trunk' into KAFKA-16907
frankvicky Jan 26, 2025
9a84510
Merge branch 'trunk' into KAFKA-16907
frankvicky Jan 28, 2025
62bca11
Merge branch 'trunk' into KAFKA-16907
frankvicky Jan 29, 2025
0517118
Merge branch 'trunk' into KAFKA-16907
frankvicky Jan 31, 2025
cdafa03
Merge branch 'trunk' into KAFKA-16907
frankvicky Feb 1, 2025
25c6477
Address comments about style
frankvicky Feb 1, 2025
9f3dcef
Merge branch 'trunk' into KAFKA-16907
frankvicky Feb 4, 2025
ffed174
Merge branch 'trunk' into KAFKA-16907
frankvicky Feb 5, 2025
f2e60bf
Merge branch 'trunk' into KAFKA-16907
frankvicky Feb 5, 2025
d6dafb2
Merge branch 'trunk' into KAFKA-16907
frankvicky Feb 6, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
import org.apache.kafka.common.requests.UpdateRaftVoterRequest;
import org.apache.kafka.common.requests.VoteRequest;
import org.apache.kafka.common.utils.Time;
import org.apache.kafka.raft.utils.ApiMessageUtils;
import org.apache.kafka.server.util.InterBrokerSendThread;
import org.apache.kafka.server.util.RequestAndCompletionHandler;

Expand Down Expand Up @@ -156,7 +157,7 @@ private void sendOnComplete(RaftRequest.Outbound request, ClientResponse clientR

private ApiMessage errorResponse(ApiMessage request, Errors error) {
ApiKeys apiKey = ApiKeys.forId(request.apiKey());
return RaftUtil.errorResponse(apiKey, error);
return ApiMessageUtils.parseErrorResponse(apiKey, error);
}

@Override
Expand Down
83 changes: 45 additions & 38 deletions raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java

Large diffs are not rendered by default.

6 changes: 4 additions & 2 deletions raft/src/main/java/org/apache/kafka/raft/LeaderState.java
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
import org.apache.kafka.raft.internals.BatchAccumulator;
import org.apache.kafka.raft.internals.KafkaRaftMetrics;
import org.apache.kafka.raft.internals.RemoveVoterHandlerState;
import org.apache.kafka.raft.utils.DynamicReconfigRpc;
import org.apache.kafka.server.common.KRaftVersion;

import org.slf4j.Logger;
Expand Down Expand Up @@ -223,7 +224,7 @@ public void resetAddVoterHandlerState(
addVoterHandlerState.ifPresent(
handlerState -> handlerState
.future()
.complete(RaftUtil.addVoterResponse(error, message))
.complete(DynamicReconfigRpc.addVoterResponse(error, message))
);
addVoterHandlerState = state;
updateUncommittedVoterChangeMetric();
Expand All @@ -241,7 +242,7 @@ public void resetRemoveVoterHandlerState(
removeVoterHandlerState.ifPresent(
handlerState -> handlerState
.future()
.complete(RaftUtil.removeVoterResponse(error, message))
.complete(DynamicReconfigRpc.removeVoterResponse(error, message))
);
removeVoterHandlerState = state;
updateUncommittedVoterChangeMetric();
Expand Down Expand Up @@ -386,6 +387,7 @@ public void appendStartOfEpochControlRecords(VoterSet.VoterNode localVoterNode,
return builder.build();
}
});
accumulator.forceDrain();
}

public long appendVotersRecord(VoterSet voters, long currentTimeMs) {
Expand Down
Loading
Loading