feat: impletment discovery service by zookeeper #779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Road2Melon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Implement the discovery service by Zookeeper.
Which issue(s) this PR fixes:
Fixes #580
Special notes for your reviewer:
I use the GetW function to monitor changes in Zookeeper nodes. When a node at the corresponding path changes, the corresponding operation is performed. I have written unit tests and have also verified the ZK registration and listening logic in incubator-seata-go-samples. By simply modifying the seatago.yml file and replacing the registry center with Zookeeper, TM and RM will be able to retrieve the TC's address. Below is the ZK configuration in seatago.yml.
# Registration Center registry: type: zk file: name: file zk: server-addr: 127.0.0.1:2181 session-timeout: 6000 connect-timeout: # not used username: "" # not used password: "" # not used node-path: /registry-seata/defaultDoes this PR introduce a user-facing change?: