Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Update join #761

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Prev Previous commit
Next Next commit
Merge branch 'master' into update_join
# Conflicts:
#	pkg/datasource/sql/exec/at/base_executor.go
#	pkg/datasource/sql/exec/at/update_executor_test.go
lxfeng1997 committed Jan 10, 2025
commit be590406f0155049aa086b265b60360fa5307522
43 changes: 42 additions & 1 deletion pkg/datasource/sql/exec/at/base_executor.go
Original file line number Diff line number Diff line change
@@ -23,7 +23,6 @@ import (
"database/sql"
"database/sql/driver"
"fmt"
"seata.apache.org/seata-go/pkg/datasource/sql/undo"
"strings"

"github.com/arana-db/parser/ast"
@@ -207,6 +206,48 @@ func (b *baseExecutor) buildRecordImages(rowsi driver.Rows, tableMetaData *types
return &types.RecordImage{TableName: tableMetaData.TableName, Rows: rowImages, SQLType: sqlType}, nil
}

func (b *baseExecutor) getNeedColumns(meta *types.TableMeta, columns []string, dbType types.DBType) []string {
var needUpdateColumns []string
if undo.UndoConfig.OnlyCareUpdateColumns && columns != nil && len(columns) > 0 {
needUpdateColumns = columns
if !b.containsPKByName(meta, columns) {
pkNames := meta.GetPrimaryKeyOnlyName()
if pkNames != nil && len(pkNames) > 0 {
for _, name := range pkNames {
needUpdateColumns = append(needUpdateColumns, name)
}
}
}
// todo If it contains onUpdate columns, add onUpdate columns
} else {
needUpdateColumns = meta.ColumnNames
}

for i := range needUpdateColumns {
needUpdateColumns[i] = AddEscape(needUpdateColumns[i], dbType)
}
return needUpdateColumns
}

func (b *baseExecutor) containsPKByName(meta *types.TableMeta, columns []string) bool {
pkColumnNameList := meta.GetPrimaryKeyOnlyName()
if len(pkColumnNameList) == 0 {
return false
}

matchCounter := 0
for _, column := range columns {
for _, pkName := range pkColumnNameList {
if strings.EqualFold(pkName, column) ||
strings.EqualFold(pkName, strings.ToLower(column)) {
matchCounter++
}
}
}

return matchCounter == len(pkColumnNameList)
}

func (u *baseExecutor) buildSelectFields(ctx context.Context, tableMeta *types.TableMeta, tableAliases string, inUseFields []*ast.Assignment) ([]*ast.SelectField, error) {
fields := make([]*ast.SelectField, 0, len(inUseFields))

You are viewing a condensed version of this merge commit. You can view the full changes here.