Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IGNITE-24096 Remove GridDhtPartitionSupplyMessageV2#AVAILABLE_SINCE #11811

Merged
merged 4 commits into from
Jan 22, 2025

Conversation

vladnovoren
Copy link
Contributor

Thank you for submitting the pull request to the Apache Ignite.

In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:

The Contribution Checklist

  • There is a single JIRA ticket related to the pull request.
  • The web-link to the pull request is attached to the JIRA ticket.
  • The JIRA ticket has the Patch Available state.
  • The pull request body describes changes that have been made.
    The description explains WHAT and WHY was made instead of HOW.
  • The pull request title is treated as the final commit message.
    The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
  • A reviewer has been mentioned through the JIRA comments
    (see the Maintainers list)
  • The pull request has been checked by the Teamcity Bot and
    the green visa attached to the JIRA ticket (see TC.Bot: Check PR)

Notes

If you need any help, please email [email protected] or ask anу advice on http://asf.slack.com #ignite channel.

@@ -444,8 +444,7 @@ else if (iter.isPartitionMissing(p)) {
if (grp.shared().kernalContext().isStopping())
return;

// Sending supply messages with error requires new protocol.
boolean sendErrMsg = demanderNode.version().compareTo(GridDhtPartitionSupplyMessageV2.AVAILABLE_SINCE) >= 0;
boolean sendErrMsg = true;
Copy link
Contributor

@nizhikov nizhikov Jan 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's rewrite it more clear:

            boolean skipErrMsg = t instanceof IgniteSpiException;

            if (skipErrMsg) {
                if (log.isDebugEnabled())
                    log.debug("Failed to send message to node (current node is stopping?) ["
                        + supplyRoutineInfo(topicId, nodeId, demandMsg) + ", msg=" + t.getMessage() + ']');
            }
            else
                U.error(log, "Failed to continue supplying ["
                    + supplyRoutineInfo(topicId, nodeId, demandMsg) + ']', t);

            try {
                if (sctx != null)
                    clearContext(sctx, log);
            }
            catch (Throwable t1) {
                U.error(log, "Failed to cleanup supplying context ["
                    + supplyRoutineInfo(topicId, nodeId, demandMsg) + ']', t1);
            }

            if (skipErrMsg)
                return;

@vladnovoren vladnovoren requested a review from nizhikov January 15, 2025 11:00
@nizhikov
Copy link
Contributor

Let's rename GridDhtPartitionSupplyMessageV2 to GridDhtPartitionSupplyErrorMessage

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
31.6% Duplication on New Code (required ≤ 5%)
4 New Code Smells (required ≤ 1)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@nizhikov nizhikov merged commit a574200 into apache:master Jan 22, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants