-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IGNITE-24096 Remove GridDhtPartitionSupplyMessageV2#AVAILABLE_SINCE #11811
Conversation
@@ -444,8 +444,7 @@ else if (iter.isPartitionMissing(p)) { | |||
if (grp.shared().kernalContext().isStopping()) | |||
return; | |||
|
|||
// Sending supply messages with error requires new protocol. | |||
boolean sendErrMsg = demanderNode.version().compareTo(GridDhtPartitionSupplyMessageV2.AVAILABLE_SINCE) >= 0; | |||
boolean sendErrMsg = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's rewrite it more clear:
boolean skipErrMsg = t instanceof IgniteSpiException;
if (skipErrMsg) {
if (log.isDebugEnabled())
log.debug("Failed to send message to node (current node is stopping?) ["
+ supplyRoutineInfo(topicId, nodeId, demandMsg) + ", msg=" + t.getMessage() + ']');
}
else
U.error(log, "Failed to continue supplying ["
+ supplyRoutineInfo(topicId, nodeId, demandMsg) + ']', t);
try {
if (sctx != null)
clearContext(sctx, log);
}
catch (Throwable t1) {
U.error(log, "Failed to cleanup supplying context ["
+ supplyRoutineInfo(topicId, nodeId, demandMsg) + ']', t1);
}
if (skipErrMsg)
return;
Let's rename |
…ionSupplyErrorMessage.
Quality Gate failedFailed conditions See analysis details on SonarQube Cloud Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE |
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
The Contribution Checklist
The description explains WHAT and WHY was made instead of HOW.
The following pattern must be used:
IGNITE-XXXX Change summary
whereXXXX
- number of JIRA issue.(see the Maintainers list)
the
green visa
attached to the JIRA ticket (see TC.Bot: Check PR)Notes
If you need any help, please email [email protected] or ask anу advice on http://asf.slack.com #ignite channel.