Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IGNITE-23747 Support timeouts for RO transactions #4902

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

IGNITE-23747 Support timeouts for RO transactions #4902

wants to merge 19 commits into from

Conversation

rpuch
Copy link
Contributor

@rpuch rpuch commented Dec 13, 2024 •
edited
Loading

https://issues.apache.org/jira/browse/IGNITE-23747

  • Timeouts for RO transactions are supported
  • A new configuration property (ignite.transaction.timeout) is added to configure default transaction timeout
  • After the timeout expires, an RO transaction gets aborted; we rely on existing cleanup mechanism to close remote cursors of this transaction
  • RO transaction is guaranteed to not be aborted automatically until its timeout expires, but it might live longer than its timeout
  • TxManager API has been revamped to make distinction between implicit and explicit transaction initiation more visible

@rpuch rpuch force-pushed the ignite-23747 branch 4 times, most recently from 3765ce4 to 62cf1af Compare December 14, 2024 11:29
@rpuch
IGNITE-23747 Support timeouts for RO transactions
4800554 
* Timeouts for RO transactions are supported
* Data availability time is used as a default RO transaction timeout
* After the timeout expires, an RO transaction gets aborted; we rely on existing cleanup mechanism to close remote cursors of this transaction and unlock its LWM locks
* RO transaction is guaranteed to not be aborted automatically until its timeout expires, but it might live longer than its timeout
* TxManager API has been revamped to make distinction between implicit and explicit transaction initiation more visible
sashapolo
sashapolo reviewed Jan 15, 2025
View reviewed changes
modules/api/src/main/java/org/apache/ignite/tx/TransactionOptions.java Outdated Show resolved Hide resolved
modules/api/src/main/java/org/apache/ignite/tx/TransactionOptions.java Outdated Show resolved Hide resolved
modules/client/src/main/java/org/apache/ignite/internal/client/tx/ClientLazyTransaction.java Outdated Show resolved Hide resolved
...egrationTest/java/org/apache/ignite/internal/tx/readonly/ItReadOnlyTxTimeoutOneNodeTest.java Outdated Show resolved Hide resolved
...sactions/src/main/java/org/apache/ignite/internal/tx/impl/TransactionExpirationRegistry.java Outdated Show resolved Hide resolved
...sactions/src/main/java/org/apache/ignite/internal/tx/impl/TransactionExpirationRegistry.java Outdated Show resolved Hide resolved
...ions/src/test/java/org/apache/ignite/internal/tx/impl/TransactionExpirationRegistryTest.java Outdated Show resolved Hide resolved
@PakhomovAlexander
Copy link
Contributor

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PakhomovAlexander PakhomovAlexander PakhomovAlexander left review comments

@sanpwc sanpwc sanpwc left review comments

@ptupitsyn ptupitsyn ptupitsyn left review comments

@isapego isapego isapego approved these changes

@sashapolo sashapolo sashapolo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rpuch @PakhomovAlexander @sashapolo @isapego @ptupitsyn @sanpwc