HADOOP-19386. Avoid adding asynchronous calls indefinitely which can cause Out-of-Memory. #7254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
@Hexiaoqiao @KeeProMise Sir, please help review this PR when you have free time, Thanks a lot. |
Hi, @hfutatzhanghb, thanks for your contribution. Functionally, I don't see any issues; however, in terms of implementation, I think we could manage an attribute called asyncCallCounter within each connect instance to control the maximum number of calls for that connect. This approach would eliminate the need for the asyncCallCounters map, where each remoteId corresponds to a connect object. Moreover, the connect object can be removed, but the asyncCallCounters map can only add data and cannot delete it. I also think asyncCallCounter field is useless if this PR applied. |
KeeProMise
reviewed
Dec 30, 2024
Comment on lines
1251
to
+1252
| final Call call = calls.remove(callId); | ||
| releaseAsyncCallPermit(); |
There was a problem hiding this comment.
I think we can add a removeCall method in the connect class, and modify the existing addCall method to include a checkAsyncCall function.
/**
* Add a call to this connection's call queue and notify
* a listener; synchronized.
* Returns false if called during shutdown.
* @param call to add
* @return true if the call was added.
*/
private synchronized boolean addCall(Call call) {
if (shouldCloseConnection.get())
return false;
checkAsyncCall();
calls.put(call.id, call);
notify();
return true;
}
private void removeCall(int callId) {
final Call call = calls.remove(callId);
releaseAsyncCallPermit();
}
hfutatzhanghb
force-pushed
the
HDFS-17699
branch
from
74eddcb to
f5b5cbd
Compare
hfutatzhanghb
changed the title
@KeeProMise Thanks sir, have fixed. |
|
refer to #7287 |
|
💔 -1 overall
This message was automatically generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Avoid adding calls indefinitely make Router Out-of-Memory.