Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(legend): fix legend action is not isolated from other legend components #20129

Merged
merged 6 commits into from
Jul 16, 2024

Conversation

plainheart
Copy link
Member

@plainheart plainheart commented Jul 8, 2024

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

  1. Enable typescript check
  2. Isolate actions dispatched by different legend components

Fixed issues

Comparison

Before After
image image

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

After this change, the legend actions can accept legendId, legendIndex, and legendName parameters.

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

Please refer to test/legend-action.html.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

Copy link

echarts-bot bot commented Jul 8, 2024

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@plainheart plainheart added this to the 5.5.2 milestone Jul 8, 2024
@echarts-bot echarts-bot bot added PR: awaiting doc Document changes is required for this PR. and removed PR: doc ready labels Jul 8, 2024
Copy link

echarts-bot bot commented Jul 8, 2024

Document changes are required in this PR. Please also make a PR to apache/echarts-doc for document changes and update the issue id in the PR description. When the doc PR is merged, the maintainers will remove the PR: awaiting doc label.

Copy link
Contributor

github-actions bot commented Jul 8, 2024

The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-20129@13fe1d9

@pull-request-size pull-request-size bot added size/S and removed size/M labels Jul 8, 2024
@plainheart plainheart force-pushed the fix/legend-action-isolation branch from c5ff583 to 7564282 Compare July 9, 2024 02:07
@plainheart plainheart marked this pull request as draft July 11, 2024 02:21
… not show after dispatching `legendAllSelect` action.
@pull-request-size pull-request-size bot added size/L and removed size/S labels Jul 11, 2024
@plainheart plainheart marked this pull request as ready for review July 11, 2024 05:38
@pull-request-size pull-request-size bot added size/M and removed size/L labels Jul 11, 2024
src/component/legend/legendAction.ts Show resolved Hide resolved
src/component/legend/legendAction.ts Outdated Show resolved Hide resolved
src/component/legend/legendAction.ts Show resolved Hide resolved
@linghaoSu linghaoSu merged commit 89cfb36 into master Jul 16, 2024
2 checks passed
Copy link

echarts-bot bot commented Jul 16, 2024

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@plainheart plainheart deleted the fix/legend-action-isolation branch July 16, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: author is committer PR: awaiting doc Document changes is required for this PR. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] 设置多个legend,每个legend中selector互相影响
2 participants