Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dataZoom): new option handleLabel.show #20082

Merged
merged 4 commits into from
Nov 6, 2024
Merged

Conversation

Ovilia
Copy link
Contributor

@Ovilia Ovilia commented Jun 27, 2024

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

This PR provides a new option dataZoom(slider).handleLabelShow and dataZoom(slider).emphasis.handleLabelShow to control when to show the handle labels.

Fixed issues

#19676

Details

Before: What was the problem?

Handle labels are shown when mouse hovering or dragging. But there is no way to always show the labels, or always hide the labels.

After: How does it behave after the fixing?

With dataZoom(slider).handleLabelShow and dataZoom(slider).emphasis.handleLabelShow, developers can now decide when to show the labels.

Document Info

One of the following should be checked.

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

Copy link

echarts-bot bot commented Jun 27, 2024

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

Document changes are required in this PR. Please also make a PR to apache/echarts-doc for document changes and update the issue id in the PR description. When the doc PR is merged, the maintainers will remove the PR: awaiting doc label.

Copy link
Contributor

github-actions bot commented Jun 27, 2024

The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-20082@c3ce6e0

@plainheart plainheart added this to the 5.5.2 milestone Jul 18, 2024
@pull-request-size pull-request-size bot added size/M and removed size/S labels Nov 6, 2024
@Ovilia Ovilia merged commit 61eeb94 into master Nov 6, 2024
2 checks passed
Copy link

echarts-bot bot commented Nov 6, 2024

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@Ovilia Ovilia deleted the feat-dataZoom-label-show branch November 6, 2024 07:40
@Ovilia Ovilia changed the title feat(dataZoom): new option handleLabelShow feat(dataZoom): new option handleLabel.show Nov 7, 2024
Ovilia added a commit to apache/echarts-doc that referenced this pull request Nov 7, 2024
@echarts-bot echarts-bot bot added PR: doc ready and removed PR: awaiting doc Document changes is required for this PR. labels Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants