Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ssr): remove redundant SVG attributes with undefined value #19461

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

plainheart
Copy link
Member

@plainheart plainheart commented Jan 2, 2024

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

#18381 set some required metadata for SVG elements but it didn't skip the undefined values, which caused the chart to generate many redundant attributes with the 'undefined' value.

In this PR, I add a precheck for dataIndex. It will skip to set SSR data if the dataIndex is not present.

Also, I fixed an unexpected assignment:

- childECData.ssrType === 'chart';
+ childECData.ssrType = 'chart';

Besides, I also added a non-null check in zrender. Please refer to ecomfe/zrender#1048.

Fixed issues

#18381

Comparison

Before After

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

Please refer to test/svg-ssr.html.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

Copy link

echarts-bot bot commented Jan 2, 2024

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@plainheart plainheart changed the title fix(ssr): remove redundant SVG attributes with undefined value. fix(ssr): remove redundant SVG attributes with undefined value Jan 2, 2024
Copy link
Contributor

github-actions bot commented Jan 2, 2024

The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-19461@7a26ce5&renderer=svg

Copy link
Contributor

@Ovilia Ovilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the help! ;)

@Ovilia Ovilia merged commit 9d61cbc into master Jan 3, 2024
2 checks passed
Copy link

echarts-bot bot commented Jan 3, 2024

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@Ovilia Ovilia deleted the fix-ssr-data-undefined branch January 3, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants