-
Notifications
You must be signed in to change notification settings - Fork 19.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(graph): straight multiple edge. close #18424 #18819
base: master
Are you sure you want to change the base?
Conversation
Thanks for your contribution! Document changes are required in this PR. Please also make a PR to apache/echarts-doc for document changes and update the issue id in the PR description. When the doc PR is merged, the maintainers will remove the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried with graph-multiple-edges-offset.html
and it seems the multiple lines are not always visible when zooming. Is offset
in pixels or what unit? If it's in pixel, then what if the width of all lines are larger than the size of the graph node size?
Hello @Ovilia, offset is a fixed value in pixel and when the width of all lines are larger than the size of the node graph edges are collapsed. This procedure take in consideration also the zoom level, so zomming in or out can cause the shrinking or the expansion of edges. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when the width of all lines are larger than the size of the node graph edges are collapsed
I think this behavior is quite unexpected to me when zooming. Can you explain why it should be like this?
Hello @Ovilia, |
Brief Information
This pull request is in the type of:
What does this PR do?
Extend the possibility to support multiple edges betwen two node in graph using offset parameters.
Fixed issues
Details
Before: What was the problem?
After: How does it behave after the fixing?
Document Info
One of the following should be checked.
Misc
ZRender Changes
Related test cases or examples to use the new APIs
graph-offset.html
graph-multiple-edges-offset.html
Others
Merging options
Other information