Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(graph): straight multiple edge. close #18424 #18819

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

DendoD96
Copy link

@DendoD96 DendoD96 commented Jun 28, 2023

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Extend the possibility to support multiple edges betwen two node in graph using offset parameters.

Fixed issues

Details

Before: What was the problem?

image

After: How does it behave after the fixing?

image

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

graph-offset.html
graph-multiple-edges-offset.html

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Jun 28, 2023

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

Document changes are required in this PR. Please also make a PR to apache/echarts-doc for document changes and update the issue id in the PR description. When the doc PR is merged, the maintainers will remove the PR: awaiting doc label.

@DendoD96 DendoD96 changed the title Feat/straight multiple edge feat(graph): straight multiple edge. close #18424 Jul 21, 2023
Copy link
Contributor

@Ovilia Ovilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried with graph-multiple-edges-offset.html and it seems the multiple lines are not always visible when zooming. Is offset in pixels or what unit? If it's in pixel, then what if the width of all lines are larger than the size of the graph node size?

@DendoD96
Copy link
Author

Hello @Ovilia, offset is a fixed value in pixel and when the width of all lines are larger than the size of the node graph edges are collapsed. This procedure take in consideration also the zoom level, so zomming in or out can cause the shrinking or the expansion of edges.

Copy link
Contributor

@Ovilia Ovilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when the width of all lines are larger than the size of the node graph edges are collapsed

I think this behavior is quite unexpected to me when zooming. Can you explain why it should be like this?

@DendoD96
Copy link
Author

Hello @Ovilia,
you are right, I had made some wrong considerations about rendering. Now I should have fixed the logic taking into account the zoom when applying the offset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants