Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance sql-using-python-udf example #1054

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Ritinikhil
Copy link

[ ] Add comprehensive comments and documentation
[ ] Implement multiple data registration methods for API compatibility Add version information printing for debugging
[ ] Improve error handling with informative messages
[ ] Add formatted table output for better readability
[ ] Include input validation through PyArrow schema
[ ] Add results verification with assertions

Author: Ritinikhil

Add comprehensive comments and documentation
Implement multiple data registration methods for API compatibility
Add version information printing for debugging
Improve error handling with informative messages
Add formatted table output for better readability
Include input validation through PyArrow schema
Add results verification with assertions
Author: Ritinikhil
@timsaucer
Copy link
Contributor

I'm not quite sure what was lacking in the examples before. For the sql example, I think all of the try/except blocks lead to more complexity than we want for a user example. What problem are you trying to solve with it?

For the substrait example, it looks like you've also removed the last portions.

It would be helpful to know what you think were the deficiencies in these examples before so I can understand why we need to update them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants