Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CXF-9057: Chunked Stream is closed regularly when Exception is thrown (MTOM) #2234

Merged
merged 1 commit into from
Feb 15, 2025

Conversation

reta
Copy link
Member

@reta reta commented Jan 25, 2025

Chunked Stream is closed regularly when Exception is thrown (MTOM)

@reta reta marked this pull request as ready for review February 11, 2025 02:44
@@ -325,6 +325,9 @@ public synchronized boolean doIntercept(Message message) {
}
pause();
throw ex;
} catch (AbortedInvocationException ex) {
abort();
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@coheigea @ffang folks would appreciate if you could validate my implementation here. Introduction of AbortedInvocationException is a best effort attempt to terminate chunking transfer that may fail in the middle. Sadly, there are no standard means to deal with that (AFAIK).

Copy link
Contributor

@ffang ffang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @reta !

@reta reta merged commit e28d4a7 into apache:main Feb 15, 2025
4 checks passed
reta added a commit that referenced this pull request Feb 15, 2025
reta added a commit that referenced this pull request Feb 16, 2025
… (MTOM) (#2234)

(cherry picked from commit e28d4a7)
(cherry picked from commit 7f14b62)

# Conflicts:
#	systests/jaxws/src/test/java/org/apache/cxf/systest/jaxws/AttachmentChunkingTest.java
reta added a commit that referenced this pull request Feb 16, 2025
… (MTOM) (#2234)

(cherry picked from commit e28d4a7)
(cherry picked from commit 7f14b62)

# Conflicts:
#	systests/jaxws/src/test/java/org/apache/cxf/systest/jaxws/AttachmentChunkingTest.java
(cherry picked from commit 07b6af3)

# Conflicts:
#	systests/jaxws/src/test/java/org/apache/cxf/systest/jaxws/AttachmentChunkingTest.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants