-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
usage: use runtime scope when running maven usage profile #10331
Conversation
Fixes error running usage server with maven. Signed-off-by: Abhishek Kumar <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.20 #10331 +/- ##
============================================
+ Coverage 16.00% 16.23% +0.23%
- Complexity 13065 13507 +442
============================================
Files 5644 5671 +27
Lines 494870 508387 +13517
Branches 59949 64260 +4311
============================================
+ Hits 79195 82539 +3344
- Misses 406838 416770 +9932
- Partials 8837 9078 +241
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm, I don't think smoke test suite will help testing this so needs a manual verification.
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12374 |
I wonder how it worked all this while.. |
tested locally
it works. |
@Pearl1594 , the usage server is not usually tested in a simulator/maven run. It is normally, even for testing, installed as a regular process. i.e. it never did |
Fixes error running usage server with maven.
Description
This PR fixes running usage server with maven:
Above command fails to bring up usage server and errors out as shown in following screenshot

Failure is related to JDBC driver not being available
48.405 [com.cloud.usage.UsageServer.main()] ERROR com.cloud.utils.db.DriverLoader - Failed to load DB driver com.mysql.cj.jdbc.Driver
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
Re-run the usage server with mvn and it executes without any issue.
How did you try to break this feature and the system with this change?