[CALCITE-6431] Implement the SINGLE_VALUE aggregation in HiveSqlDiale… #4235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before this #3817 Hive and Spark don't throw exceptions as we expected. It's okay now. |
|
@mihaibudiu Could you please review this PR? The previous PR was not executed as expected. I have tested it in our service. |
mihaibudiu
approved these changes
Mar 21, 2025
core/src/main/java/org/apache/calcite/sql/dialect/HiveSqlDialect.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/apache/calcite/sql/dialect/HiveSqlDialect.java
Outdated
Show resolved
Hide resolved
…ct And SparkSQLDialect
NobiGo
force-pushed
the
CALCITE-6431-NEW
branch
from
61f3b21 to
1ddf8b5
Compare
NobiGo
added
the
LGTM-will-merge-soon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ct And SparkSQLDialect