Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CALCITE-6756] Preserving CAST of STRING operand in binary comparison… #4151

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[CALCITE-6756] Preserving CAST of STRING operand in binary comparison… #4151

wants to merge 3 commits into from

Conversation

NobiGo
Copy link
Contributor

@NobiGo NobiGo commented Jan 18, 2025

… for PostgreSQL

mihaibudiu
mihaibudiu reviewed Jan 18, 2025
View reviewed changes
core/src/main/java/org/apache/calcite/sql/dialect/PostgresqlSqlDialect.java
if (isNumericType) {
return false;
}
return supportImplicit && RexUtil.isLiteral(operand0, false);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure only literals are a problem?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Literals don't need the cast, others need it. I add a unit test.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaibudiu mihaibudiu mihaibudiu left review comments

@ILuffZhe ILuffZhe ILuffZhe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NobiGo @mihaibudiu @ILuffZhe