[CALCITE-6780] AbstractSqlTester fails to build query for expression TRIM(string) #4149
+28
−19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch skips extracting trimmed character for TRIM function in CheckFramework.
Hence, after abstractSqlTester.buildQuery2(), expression
trim(' aAa ')
will beselect trim(p0) from (values (' aAa ')) as t(p0)
.And expression
trim(both ' ' from ' aAa ')
will beselect trim(both ' ' from p0) from (values (' aAa ')) as t(p0)
.