Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CALCITE-6780] AbstractSqlTester fails to build query for expression TRIM(string) #4149

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ILuffZhe
Copy link
Contributor

This patch skips extracting trimmed character for TRIM function in CheckFramework.
Hence, after abstractSqlTester.buildQuery2(), expression trim(' aAa ') will be select trim(p0) from (values (' aAa ')) as t(p0).
And expression trim(both ' ' from ' aAa ') will be select trim(both ' ' from p0) from (values (' aAa ')) as t(p0).

Copy link
Contributor

@mihaibudiu mihaibudiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is this related to the CheckerFramework?
I suspect that the JIRA title is wrong.
Maybe there is a problem in the AbstractSqlTester, but that's unrelated.

@ILuffZhe
Copy link
Contributor Author

How is this related to the CheckerFramework? I suspect that the JIRA title is wrong. Maybe there is a problem in the AbstractSqlTester, but that's unrelated.

You are right this is not about CheckerFramework. I'm considering changing the summary to AbstractSqlTester failed to build query for expression TRIM(string). What do you think?

@mihaibudiu
Copy link
Contributor

that is better, but I would say "fails" instead of "failed"

@ILuffZhe ILuffZhe changed the title [CALCITE-6780] CheckerFramework failed to build query for expression TRIM(string) [CALCITE-6780] AbstractSqlTester fails to build query for expression TRIM(string) Jan 17, 2025
@mihaibudiu mihaibudiu added the LGTM-will-merge-soon Overall PR looks OK. Only minor things left. label Jan 18, 2025
@mihaibudiu
Copy link
Contributor

I think we can merge this after squashing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LGTM-will-merge-soon Overall PR looks OK. Only minor things left.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants