Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IndexOutOfBoundsException invoking expansion service #34428

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix IndexOutOfBoundsException invoking expansion service #34428

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions ...pansion-service/src/main/java/org/apache/beam/sdk/expansion/service/ExpansionService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -580,10 +580,8 @@ private Map<String, TransformProvider> loadRegisteredTransforms() {

@VisibleForTesting
/*package*/ ExpansionApi.ExpansionResponse expand(ExpansionApi.ExpansionRequest request) {
LOG.info(
"Expanding '{}' with URN '{}'",
request.getTransform().getUniqueName(),
request.getTransform().getSpec().getUrn());
final String urn = request.getTransform().getSpec().getUrn();
LOG.info("Expanding '{}' with URN '{}'", request.getTransform().getUniqueName(), urn);
LOG.debug("Full transform: {}", request.getTransform());
Set<String> existingTransformIds = request.getComponents().getTransformsMap().keySet();

Expand Down Expand Up @@ -625,8 +623,6 @@ private Map<String, TransformProvider> loadRegisteredTransforms() {
}
}));

String urn = request.getTransform().getSpec().getUrn();

TransformProvider transformProvider = getRegisteredTransforms().get(urn);
if (transformProvider == null) {
if (getUrn(ExpansionMethods.Enum.JAVA_CLASS_LOOKUP).equals(urn)) {
Expand All @@ -649,8 +645,7 @@ private Map<String, TransformProvider> loadRegisteredTransforms() {
? transformProvider
: ExpansionServiceSchemaTransformProvider.of();
} else {
throw new UnsupportedOperationException(
"Unknown urn: " + request.getTransform().getSpec().getUrn());
throw new UnsupportedOperationException("Unknown urn: " + urn);
}
}

Expand Down Expand Up @@ -814,6 +809,10 @@ public void close() throws Exception {
}

public static void main(String[] args) throws Exception {
if (args.length < 1) {
printUsage();
System.exit(1);
}
int port = Integer.parseInt(args[0]);
System.out.println("Starting expansion service at localhost:" + port);

Expand Down Expand Up @@ -874,6 +873,10 @@ public static void main(String[] args) throws Exception {
server.awaitTermination();
}

private static void printUsage() {
System.err.println("Usage: java -jar <expansion-service-jar> port [pipeline-options]");
}

private static class NotRunnableRunner extends PipelineRunner<PipelineResult> {
public static NotRunnableRunner fromOptions(PipelineOptions opts) {
return new NotRunnableRunner();
Expand Down
Loading