Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-45514: [CI][C++][Docs] Set CUDAToolkit_ROOT explicitly in debian-docs #45520

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

kou
Copy link
Member

@kou kou commented Feb 13, 2025

Rationale for this change

CMake's FindCUDAToolkit.cmake uses /usr/lib/cuda/ as the default prefix but Debian's nvidia-cuda-dev uses /usr as prefix.

What changes are included in this PR?

Set CUDAToolkit_ROOT=/usr explicitly.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

@kou
Copy link
Member Author

kou commented Feb 13, 2025

@github-actions crossbow submit test-debian-12-docs

Copy link

⚠️ GitHub issue #45514 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Feb 13, 2025
Copy link

Revision: 3a7b55a

Submitted crossbow builds: ursacomputing/crossbow @ actions-5b3d3714b0

Task Status
test-debian-12-docs GitHub Actions

Copy link
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kou , LGTM

@@ -133,4 +133,5 @@ ENV ARROW_ACERO=ON \
ARROW_S3=ON \
ARROW_USE_GLOG=OFF \
CMAKE_UNITY_BUILD=ON \
CUDAToolkit_ROOT=/usr \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you know is installed there?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use apt-file search:

$ sudo apt-file search cuda_runtime.h
libgridtools-dev: /usr/include/gridtools/common/cuda_runtime.hpp
nvidia-cuda-dev: /usr/include/cuda_runtime.h

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kou! I didn't know about apt-file search

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Feb 13, 2025
@kou kou merged commit 152eb87 into apache:main Feb 14, 2025
33 of 35 checks passed
@kou kou removed the awaiting merge Awaiting merge label Feb 14, 2025
@kou kou deleted the ci-docs branch February 14, 2025 00:19
@github-actions github-actions bot added the awaiting changes Awaiting changes label Feb 14, 2025
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 152eb87.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 5 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting changes Awaiting changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants