-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-45514: [CI][C++][Docs] Set CUDAToolkit_ROOT explicitly in debian-docs #45520
Conversation
@github-actions crossbow submit test-debian-12-docs |
|
Revision: 3a7b55a Submitted crossbow builds: ursacomputing/crossbow @ actions-5b3d3714b0
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kou , LGTM
@@ -133,4 +133,5 @@ ENV ARROW_ACERO=ON \ | |||
ARROW_S3=ON \ | |||
ARROW_USE_GLOG=OFF \ | |||
CMAKE_UNITY_BUILD=ON \ | |||
CUDAToolkit_ROOT=/usr \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How did you know is installed there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can use apt-file search
:
$ sudo apt-file search cuda_runtime.h
libgridtools-dev: /usr/include/gridtools/common/cuda_runtime.hpp
nvidia-cuda-dev: /usr/include/cuda_runtime.h
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kou! I didn't know about apt-file search
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 152eb87. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 5 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
CMake's
FindCUDAToolkit.cmake
uses/usr/lib/cuda/
as the default prefix but Debian'snvidia-cuda-dev
uses/usr
as prefix.What changes are included in this PR?
Set
CUDAToolkit_ROOT=/usr
explicitly.Are these changes tested?
Yes.
Are there any user-facing changes?
No.